JDK-8261304 : Clean up anomalies identified in code review comments
  • Type: Bug
  • Component: client-libs
  • Sub-Component: 2d
  • Affected Version: internal
  • Priority: P4
  • Status: Resolved
  • Resolution: Fixed
  • OS: os_x
  • CPU: x86_64
  • Submitted: 2021-02-08
  • Updated: 2021-02-08
  • Resolved: 2021-02-08
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
Other
internalFixed
Related Reports
Blocks :  
JDK-8260931 - Implement JEP 382: New macOS Rendering Pipeline
Description
Lanai code review PR - https://github.com/openjdk/jdk/pull/2403 has identified few minor cleanups-

1) Remove only white space added to src/java.desktop/share/native/libawt/java2d/SurfaceData.c
2) src/java.desktop/macosx/classes/sun/java2d/metal/MTLGraphicsConfig.java - update copyright header to have 2019, 2021
3) Remove empty spacing added in files -
     -  src/java.desktop/macosx/classes/sun/lwawt/macosx/CPlatformView.java 
    - src/java.desktop/macosx/classes/sun/lwawt/macosx/CWarningWindow.java
4) Correct end of interface description comment in  src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/EncoderManager.h
5) Typo in  src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/EncoderManager.m  - "generateion" should be "generation"
6) src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLGraphicsConfig.m -- line 83 - should be jboolean : This code is mixing types; it should be jboolean metalSupported
7) minor corrections in -  src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLPaints.h 
8)  src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLSurfaceDataBase.h -- replace reference to openGL with Metal in comment
9 )  src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLTextRenderer.m  -- replace reference to openGL drivers