JDK-8261156 : [lworld] Re-enable C1 testing after mainline issues are fixed
  • Type: Bug
  • Component: hotspot
  • Sub-Component: compiler
  • Affected Version: repo-valhalla
  • Priority: P3
  • Status: Resolved
  • Resolution: Fixed
  • Submitted: 2021-02-04
  • Updated: 2021-02-12
  • Resolved: 2021-02-12
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
Other
repo-valhallaFixed
Related Reports
Relates :  
JDK-8261225 - TieredStopAtLevel should have no effect if TieredCompilation is disabled
Relates :  
JDK-8261229 - MethodData is not correctly initialized with TieredStopAtLevel=3
Description
After merge JDK-8251462 Simplify compilation policy:

make exploded-test TEST=hotspot_valhalla  TEST_VM_OPTS="-XX:TieredStopAtLevel=1"

compiler/valhalla/inlinetypes/TestLWorldProfiling.java fails because compilation level 4 is not available with -XX:-TieredCompilation and -XX:TieredStopAtLevel=1 due to JDK-8261225:

WB error: invalid compilation level 4

stderr: [Exception in thread "main" java.lang.RuntimeException: Unexpected compilation level for public boolean compiler.valhalla.inlinetypes.TestLWorldProfiling.test26(java.lang.Object,java.lang.Object): expected 1 to equal 4
	at jdk.test.lib.Asserts.fail(Asserts.java:594)
	at jdk.test.lib.Asserts.assertEquals(Asserts.java:205)
	at jdk.test.lib.Asserts.assertEQ(Asserts.java:178)
	at compiler.valhalla.inlinetypes.InlineTypeTest.run(InlineTypeTest.java:771)
	at compiler.valhalla.inlinetypes.InlineTypeTest.run(InlineTypeTest.java:451)
	at compiler.valhalla.inlinetypes.TestLWorldProfiling.main(TestLWorldProfiling.java:82)
]

Several tests crash due to JDK-8261229:

compiler/valhalla/inlinetypes/TestNullableArrays.java
compiler/valhalla/inlinetypes/TestLWorld.java
compiler/valhalla/inlinetypes/TestArrays.java

src/hotspot/share/c1/c1_Runtime1.cpp:473), pid=22107, tid=22108
# assert(data != __null && data->is_ArrayLoadStoreData()) failed: incorrect profiling entry

tack: [0x00007f0314d8f000,0x00007f0314e90000], sp=0x00007f0314e8cc10, free space=1015k
Native frames: (J=compiled Java code, A=aot compiled Java code, j=interpreted, Vv=VM code, C=native code)
V [libjvm.so+0x831899] profile_flat_array(JavaThread*)+0x269
V [libjvm.so+0x834f78] Runtime1::store_flattened_array(JavaThread*, flatArrayOopDesc*, int, oopDesc*)+0x358
v ~RuntimeStub::store_flattened_array Runtime1 stub
J 199 c1 compiler.valhalla.inlinetypes.TestLWorld.test31Interface([Lcompiler/valhalla/inlinetypes/MyInterface;Lcompiler/valhalla/inlinetypes/MyInterface;I)V (8 bytes) @ 0x00007f03019f29db [0x00007f03019f27c0+0x000000000000021b]
j compiler.valhalla.inlinetypes.TestLWorld.test31Interface_verifier(Z)V+29
j jdk.internal.reflect.GeneratedMethodAccessor5.invoke(Ljava/lang/Object;[Ljava/lang/Object;)Ljava/lang/Object;+63
j jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(Ljava/lang/Object;[Ljava/lang/Object;)Ljava/lang/Object;+6 java.base@17-lworld3ea
j java.lang.reflect.Method.invoke(Ljava/lang/Object;[Ljava/lang/Object;)Ljava/lang/Object;+59 java.base@17-lworld3ea
j compiler.valhalla.inlinetypes.InlineTypeTest.run([Ljava/lang/Class;)V+349
j compiler.valhalla.inlinetypes.InlineTypeTest.run([Ljava/lang/String;[Ljava/lang/Class;)V+43
j compiler.valhalla.inlinetypes.TestLWorld.main([Ljava/lang/String;)V+45
Comments
We should then also add a run with TieredStopAtLevel=3
05-02-2021
I'll leave this bug open to re-enable C1 testing once the issues are fixed in mainline.
05-02-2021
TestLWorldProfiling fails because compilation level 4 is not available. I think this is a mainline bug and filed JDK-8261225. The crashes are due to another mainline bug, I've filed JDK-8261229.
05-02-2021