JDK-8260471 : Change SystemDictionary::X_klass calls to vmClasses::X_klass
  • Type: Sub-task
  • Component: hotspot
  • Sub-Component: runtime
  • Priority: P4
  • Status: Resolved
  • Resolution: Fixed
  • Submitted: 2021-01-26
  • Updated: 2021-02-08
  • Resolved: 2021-02-02
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 17
17 b08Fixed
Description
To help the review of JDK-8260467, we make the mechanical changes like the following in this Subtask:

    SystemDictionary::Object_klass()
    SystemDictionary::Throwable_klass_is_loaded()
    SystemDictionary::box_klass_type()

to

    vmClasses::Object_klass()
    vmClasses::Throwable_klass_is_loaded()
    vmClasses::box_klass_type()

This will limit JDK-8260467 (which has the functional changes) to about 35 source files. This Subtask will change about 170 source files.
Comments
Changeset: ffbcf1b0 Author: Ioi Lam <iklam@openjdk.org> Date: 2021-02-02 23:40:29 +0000 URL: https://git.openjdk.java.net/jdk/commit/ffbcf1b0
02-02-2021
I can change this subtask to a follow-on bug. For the first step, I subclass SystemDirectory from vmClass, so SystemDirectory::Object_klass() automatically becomes an alias of vmClasses::Object_klass(). That way I don't need to make the massive change all at once.
27-01-2021
I don't quite follow that - how can you change the SD but not change the calls?? And subtasks are supposed to be completed prior to the main bug.
27-01-2021
I plan to push the main bug first, and then merge down to my second branch, and then push second bug.
27-01-2021
IIUC this subtask can't exist without the changes in the main bug, and can't be pushed separately. We don't generally create subtasks like this. You could simply perform separate commits in your branch prior to the PR, and then reviewers can look at individual commits to make the review more digestable. Or "old school" you could generate distinct webrevs.
27-01-2021
Here's a preview of the changes. http://cr.openjdk.java.net/~iklam/jdk17/8260471-decouple-vmClasses-and-SystemDictionary/
26-01-2021