JDK-8257828 : SafeFetch may crash if invoked in non-JavaThreads
- Type: Bug
- Component: hotspot
- Sub-Component: runtime
- Affected Version: 11,16
- Priority: P4
- Status: Resolved
- Resolution: Fixed
- Submitted: 2020-12-07
- Updated: 2021-05-20
- Resolved: 2020-12-15
The Version table provides details related to the release that this issue/RFE will be addressed.
Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.
To download the current JDK release, click here.
Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.
To download the current JDK release, click here.
| JDK 11 | JDK 17 |
|---|---|
| 11.0.12Fixed | 17 b02Fixed  |
Related Reports
|
Relates :
|
|
|
Relates :
|
Description
In our primary hotspot signal handlers, SafeFetch handling is limited to JavaThread objects:
```
JavaThread* thread = NULL;
...
if(t->is_Java_thread()) {
thread = (JavaThread*)t;
}
...
if (info != NULL && uc != NULL && thread != NULL) {
pc = (address) os::Linux::ucontext_get_pc(uc);
if (StubRoutines::is_safefetch_fault(pc)) {
```
As a result of this, using SafeFetch may crash non-JavaThreads if the location is invalid. E.g. using SafeFetch inside a VMOperation may crash the VM.
This is unfortunate since SafeFetch is used for os::is_readable_pointer() which explicitly promises to not crash. It is used e.g. in os::print_hex_dump(). There is also no reason why SafeFetch would not work for non-JavaThreads. In fact, SafeFetch handling for the secondary signal handler works just fine for all threads.
This is an old bug, unrelated to the recent Posix cleanups. AFAICS it has been there at least since Jdk11.
Comments
|