JDK-8256859 : PPC64 builds broken after JDK-8254231
  • Type: Bug
  • Component: hotspot
  • Sub-Component: other
  • Affected Version: 16
  • Priority: P2
  • Status: Closed
  • Resolution: Duplicate
  • Submitted: 2020-11-23
  • Updated: 2024-02-21
  • Resolved: 2020-11-24
Related Reports
Duplicate :  
JDK-8256922 - ppc, ppcle build broken after JDK-8254231
Relates :  
JDK-8254231 - Implementation of Foreign Linker API (Incubator)
Description
In file included from /home/buildbot/worker/build-jdkX-linux/build/src/hotspot/share/prims/foreign_globals.cpp:25:0:
/home/buildbot/worker/build-jdkX-linux/build/src/hotspot/share/prims/foreign_globals.hpp:29:37: fatal error: foreign_globals_ppc.hpp: No such file or directory
 #include CPU_HEADER(foreign_globals)
                                     ^
Comments
Didn't see your issue, sorry
24-11-2020
Ran out of time implementing this. Current draft follows what other platforms do: https://github.com/openjdk/jdk/compare/master...shipilev:JDK-8256859-ppc64-foreign ...but with a problem: ProgrammableInvoker::Generator::Generator(CodeBuffer* code, const ABIDescriptor* abi, const BufferLayout* layout) : StubCodeGenerator(code), _abi(abi), // <---- build error here _layout(layout) {} ...because frame_ppc.hpp already defines: #define _abi(_component) \ (offset_of(frame::abi_reg_args, _component)) Macro needs renaming, I think. Or we need to #undef _abi -- which is riskier, because in some other place we could have a silent substitution that does not yield the build error. Feel free to pick up from where I left.
23-11-2020
[~mdoerr], would you like to take this on? Otherwise, I can hack up the implementation later tonight.
23-11-2020