JDK-8256365 : Clean up vtable initialization code
  • Type: Enhancement
  • Component: hotspot
  • Sub-Component: runtime
  • Affected Version: 16
  • Priority: P4
  • Status: Resolved
  • Resolution: Fixed
  • Submitted: 2020-11-13
  • Updated: 2020-11-26
  • Resolved: 2020-11-18
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 16
16 b26Fixed
Related Reports
Relates :  
JDK-8061949 - klassVTable::initialize_vtable exhibits quadratic time complexity
Relates :  
JDK-8256674 - assert failed: "old methods should not be in vtable"
Relates :  
JDK-8256640 - assert(!m->is_old() || ik()->is_being_redefined()) failed: old methods should not be in vtable
Description
I was looking through this code because of JDK-8061949 and want to do some minor cleanups.
1. There's a function in the wrong place (is_override)
2. methodHandles that use mh()->is_native(), with extra (),
3. some methods declared with TRAPS, that don't trap
4. some multi-clause conditionals with confusing formatting
5. extra InstanceKlass::cast() casts
6. some useless asserts
7. and potentially a bug with RedefineClasses where the method being added to the vtable may have been redefined in the constraint verification call.  (noreg-hard)
Comments
Changeset: fa8dce4f Author: Coleen Phillimore <coleenp@openjdk.org> Date: 2020-11-18 14:12:48 +0000 URL: https://github.com/openjdk/jdk/commit/fa8dce4f
18-11-2020