JDK-8255564 : InterpreterMacroAssembler::remove_activation() needs to restore thread right after VM call on x86_32
- Type: Bug
- Component: hotspot
- Sub-Component: runtime
- Affected Version: 16
- Priority: P2
- Status: Resolved
- Resolution: Fixed
- Submitted: 2020-10-28
- Updated: 2021-01-13
- Resolved: 2020-10-29
The Version table provides details related to the release that this issue/RFE will be addressed.
Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.
To download the current JDK release, click here.
Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.
To download the current JDK release, click here.
| JDK 16 |
|---|
16 b23Fixed  |
Related Reports
|
Relates :
|
Description
Currently, it restores thread register a bit too late, that results crashes with Shenandoah GC on x86_32 JVM. diff --git a/src/hotspot/cpu/x86/interp_masm_x86.cpp b/src/hotspot/cpu/x86/interp_masm_x86.cpp index 9274f298759..9c1376a33c6 100644 --- a/src/hotspot/cpu/x86/interp_masm_x86.cpp +++ b/src/hotspot/cpu/x86/interp_masm_x86.cpp @@ -1005,9 +1005,9 @@ void InterpreterMacroAssembler::remove_activation( push(state); set_last_Java_frame(rthread, noreg, rbp, (address)pc()); super_call_VM_leaf(CAST_FROM_FN_PTR(address, InterpreterRuntime::at_unwind), rthread); + NOT_LP64(get_thread(rthread);) // call_VM clobbered it, restore reset_last_Java_frame(rthread, true); pop(state); - NOT_LP64(get_thread(rthread);) // call_VM clobbered it, restore bind(fast_path);
Comments
|