JDK-8255005 : Fix indentation levels in classFileParser.cpp
  • Type: Enhancement
  • Component: hotspot
  • Sub-Component: runtime
  • Affected Version: 16
  • Priority: P4
  • Status: Resolved
  • Resolution: Fixed
  • Submitted: 2020-10-19
  • Updated: 2020-11-05
  • Resolved: 2020-10-30
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 16
16 b23Fixed
Related Reports
Relates :  
Description
The indentiation levels are off in this block of code in classFileParser.cpp:

          } else if (_major_version >= JAVA_16_VERSION) {
          if (tag == vmSymbols::tag_record()) {
              // Skip over Record attribute if super class is not java.lang.Record.
              if (cp->klass_name_at(_super_class_index) == vmSymbols::java_lang_Record()) {
              if (parsed_record_attribute) {
                classfile_parse_error("Multiple Record attributes in class file %s", THREAD);
                return;
              }
              // Check that class is final and not abstract.
              if (!_access_flags.is_final() || _access_flags.is_abstract()) {
                classfile_parse_error("Record attribute in non-final or abstract class file %s", THREAD);
                return;
              }
              parsed_record_attribute = true;
              record_attribute_start = cfs->current();
              record_attribute_length = attribute_length;
            } else if (log_is_enabled(Info, class, record)) {
              ResourceMark rm(THREAD);
                log_info(class, record)(
                  "Ignoring Record attribute in class %s because super type is not java.lang.Record",
                  _class_name->as_C_string());
              }
            }
            cfs->skip_u1(attribute_length, CHECK);
          } else {

Comments
Changeset: 8a065ef2 Author: Harold Seigel <hseigel@openjdk.org> Date: 2020-10-30 12:56:15 +0000 URL: https://github.com/openjdk/jdk/commit/8a065ef2
30-10-2020

This change must be done after support for Records as a non-preview feature is pushed.
19-10-2020