JDK-8254285 : G1: Remove "What is this about" comment in G1CollectedHeap.cpp
  • Type: Enhancement
  • Component: hotspot
  • Sub-Component: gc
  • Affected Version: 16
  • Priority: P4
  • Status: Resolved
  • Resolution: Fixed
  • Submitted: 2020-10-09
  • Updated: 2020-10-15
  • Resolved: 2020-10-09
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 16
16 b20Fixed
Related Reports
Relates :  
Description
In g1CollectedHeap.cpp there is this comment:

  // FIXME: what is this about?
  // I'm ignoring the "fill_newgen()" call if "alloc_event_enabled"
  // is set.

that does not make sense at all as the FIXME indicates. This comment has been introduced with the open sourcing of G1 (JDK-6711316).

Fill_newgen() has as far as I could gather some method used in Serial GC that has been removed long ago too.

Let's remove this comment.
Comments
Changeset: a95590d0 Author: Thomas Schatzl <tschatzl@openjdk.org> Date: 2020-10-09 09:55:57 +0000 URL: https://git.openjdk.java.net/jdk/commit/a95590d0
09-10-2020