JDK-8252816 : JvmtiEnvThreadState::clear_to_frame_pop() is not used
  • Type: Bug
  • Component: hotspot
  • Sub-Component: jvmti
  • Affected Version: 16
  • Priority: P4
  • Status: Resolved
  • Resolution: Fixed
  • Submitted: 2020-09-04
  • Updated: 2024-11-22
  • Resolved: 2020-09-08
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 16
16 b15Fixed
Related Reports
Relates :  
JDK-8242427 - JVMTI frame pop operations should use Thread-Local Handshakes
Relates :  
JDK-8242427 - JVMTI frame pop operations should use Thread-Local Handshakes
Description
https://mail.openjdk.java.net/pipermail/serviceability-dev/2020-September/032915.html

We can remove both JvmtiEventController::clear_to_frame_pop() and  JvmtiEnvThreadState::clear_to_frame_pop() because JvmtiEventController::clear_to_frame_pop() is only called by JvmtiEnvThreadState::clear_to_frame_pop(), and JvmtiEnvThreadState::clear_to_frame_pop() seems to be unused in any place.
Comments
Changeset: 704f784c Author: Robbin Ehn <rehn@openjdk.org> Date: 2020-09-08 13:45:19 +0000 URL: https://git.openjdk.java.net/jdk/commit/704f784c
08-09-2020
Here's my comment from the JDK-8242427 code review thread: On 2020/09/05 5:27, Daniel D. Daugherty wrote: > old L996: JvmtiEventController::clear_to_frame_pop(JvmtiEnvThreadState *ets, JvmtiFramePop fpop) { > old L997: MutexLocker mu(SafepointSynchronize::is_at_safepoint() ? NULL : JvmtiThreadState_lock); > This function JvmtiEventController::clear_to_frame_pop() is only > called by JvmtiEnvThreadState::clear_to_frame_pop(int frame_number). > I cannot find any code that calls JvmtiEnvThreadState::clear_to_frame_pop(). > > JvmtiEnvThreadState::set_frame_pop(int frame_number) is > called from jvmtiEnv.cpp and jvmtiEnvBase.cpp. > JvmtiEnvThreadState::clear_frame_pop(int frame_number) is > called from jvmtiExport.cpp and jvmtiThreadState.cpp. > > It looks like JvmtiEnvThreadState::clear_to_frame_pop() is > unused to me, but another pair of eyes would be good. If it > is unused, a followup bug for analysis and removal would be > good. Just want to make sure that if the function was used > in the past, that the removal was intentional rather than a > typo. Easy to do with similarly named functions...
05-09-2020