JDK-8252462 : Deprecate for removal css Selector and ShapeConverter constructors
  • Type: CSR
  • Component: javafx
  • Sub-Component: scenegraph
  • Priority: P3
  • Status: Closed
  • Resolution: Approved
  • Fix Versions: openjfx16
  • Submitted: 2020-08-27
  • Updated: 2020-09-02
  • Resolved: 2020-09-02
Related Reports
CSR :  
Description
Summary
-------

Deprecate the public constructor of javafx.css.Selector and javafx.css.converter.ShapeConverter

Problem
-------

 - Constructor for class javafx.css.Selector should not be public as it
   is only extended by classes in same package.
 - Constructor for class javafx.css.converter.ShapeConverter should not
   be public as its a singleton class.

Solution
--------

 Deprecate the constructor of both class javafx.css.Selector and javafx.css.converter.ShapeConverter for removal.

Specification
-------------

    /**
     * @deprecated This constructor was exposed erroneously and will be removed in the next version. Use {@link #createSelector(String)} instead.
     */
    @Deprecated(since="16", forRemoval=true)
    public Selector() {
    }

    /**
     * @deprecated This constructor was exposed erroneously and will be removed in the next version. Use {@link #getInstance()} instead.
     */
    @Deprecated(since="16", forRemoval=true)
    public ShapeConverter() {
    }


Comments
Moving to Approved.
02-09-2020

[~bchoudhary] After you update the Selector docs to match the change that came from the code review, then I'll "Review" the CSR and you can finalize it.
29-08-2020

Moving to Provisional.
28-08-2020

Looks good. I'll formally "Review" it once I test the patch and look at the generated API docs.
28-08-2020