JDK-8250990 : Consolidate object copying code for CDS static/dynamic archive dumping
  • Type: Sub-task
  • Component: hotspot
  • Sub-Component: runtime
  • Priority: P4
  • Status: Resolved
  • Resolution: Fixed
  • Submitted: 2020-08-03
  • Updated: 2024-11-20
  • Resolved: 2020-08-14
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 16
16 b12Fixed
Related Reports
Duplicate :  
JDK-8245597 - Avoid using ClassLoaderDataGraph::loaded_classes_do during -Xshare:dump
Relates :  
JDK-8250989 - Consolidate buffer allocation code for CDS static/dynamic dumping
Relates :  
JDK-8251557 - Avoid dumping unused symbols/strings into the CDS archive
Description
Both static and dynamic archive dumping use MetaspaceClosure for copying MetaspaceObjs into an output buffer:

http://hg.openjdk.java.net/jdk/jdk/file/4d36e29a5410/src/hotspot/share/memory/metaspaceShared.cpp#l1351
http://hg.openjdk.java.net/jdk/jdk/file/4d36e29a5410/src/hotspot/share/memory/dynamicArchive.cpp#l168

There's a lot of duplication between the two variants. They should be consolidated.
Comments
URL: https://hg.openjdk.java.net/jdk/jdk/rev/7dfca7d32df8 User: iklam Date: 2020-08-14 01:41:51 +0000
14-08-2020
Review thread: https://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2020-August/040937.html
06-08-2020