JDK-8246805 : Incorrect copyright header in TestInvalidTieredStopAtLevel.java
  • Type: Bug
  • Component: hotspot
  • Sub-Component: compiler
  • Affected Version: 11,15
  • Priority: P3
  • Status: Resolved
  • Resolution: Fixed
  • Submitted: 2020-06-09
  • Updated: 2024-10-17
  • Resolved: 2020-07-16
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 11 JDK 15 JDK 16
11.0.10-oracleFixed 15 b33Fixed 16Fixed
Related Reports
Relates :  
JDK-8241232 - -XX:+BootstrapJVMCI is not compatible with TieredStopAtLevel < CompLevel_full_optimization
Description
The following file has an incorrect header format: 

open/test/hotspot/jtreg/compiler/jvmci/errors/TestInvalidTieredStopAtLevel.java

   * Copyright (C) 2020 THL A29 Limited, a Tencent company. All rights reserved.
Comments
URL: https://hg.openjdk.java.net/jdk/jdk15/rev/069d28dab1ec User: jiefu Date: 2020-07-16 03:55:41 +0000
16-07-2020
Ok, I will do it. Sorry to miss this message.
16-07-2020
[~jiefu], could you please fix the legal notice of TestInvalidTestStopAtLevel file to be GPLv2 as in `make/templates/gpl-header` (modulo 1st string w/ Oracle copyright notice) ?
30-06-2020
I'd also note that tests should have "pure" GPL2 and not GPL2+CPE
29-06-2020
[~ysatowse], thanks I do see now that the legal notice in this file doesn't match the expectation. I have a question though, `open/make/templates/gpl-*header` files have 'Copyright (c) %YEARS% Oracle and/or its affiliates. All rights reserved.' as their first line, which kinda suggests that it's required that there is Oracle's copyright line regardless of the origin of the file. this doesn't sound right to me, given some files can be (and there are existing precedents) not created, not modified, and not maintained by Oracle. could you please clarify if it's a case? and if it is why is the requirement? (sorry I didn't have a chance to fully read/understand `make/scripts/lic_check.sh` yet)
15-06-2020
ILW = LLL = P5
15-06-2020
[~iignatyev] Sorry, the copyright line looks no problem. The license notice needs to follow the templates you can see in make/templates/{gpl-header, gpl-cp-header}
15-06-2020