JDK-8245035 : Clean up os::split_reserved_memory()
  • Type: Enhancement
  • Component: hotspot
  • Sub-Component: runtime
  • Affected Version: 15
  • Priority: P4
  • Status: Resolved
  • Resolution: Fixed
  • Submitted: 2020-05-14
  • Updated: 2020-09-26
  • Resolved: 2020-05-19
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 15
15 b24Fixed
Related Reports
Blocks :  
Blocks :  
Relates :  
Description
os::split_reserved_memory() should be cleaned up a bit.

It is used to split reserved memory regions in order to make them independent units. This only matters when releasing them, so after splitting these regions should be releasable independently from each other.

This only matters on Windows, which is the only platform with a non-empty implementation, since virtual memory can only be released as a unit (opposed to mmap api, where sub regions can be unmapped individually).

Improvements:
- the interface should be commented
- the "realloc" parameter can be removed. It has never not been true on all code paths - had it been, it would have been an error on windows resulting in loosing one of the two sides of the split.
- the many non-windows implementations can be combined in posix.cpp.



Comments
URL: https://hg.openjdk.java.net/jdk/jdk/rev/88142d00ec1c User: stuefe Date: 2020-05-19 19:06:32 +0000
19-05-2020