JDK-8244490 : [vector] Move Vector API micro benchmarks under test/micro
  • Type: Bug
  • Component: hotspot
  • Sub-Component: compiler
  • Affected Version: repo-panama
  • Priority: P4
  • Status: Resolved
  • Resolution: Fixed
  • Submitted: 2020-05-06
  • Updated: 2021-06-10
  • Resolved: 2021-06-10
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
Other
repo-panamaFixed
Related Reports
Blocks :  
JDK-8225463 - consider usage of test/micro as functional tests
Relates :  
JDK-8223347 - Integration of Vector API (Incubator)
Description
Vector API micro benchmarks are currently located under test/jdk/jdk/incubator/vector/benchmark which makes them rather as "dead" code without possibility to built and run.

The proper location for micro benchmarks is actually test/micro/ directory.
It would be nice to move Vector API benchmarks there so they can be built automatically as part 'test-image' make target.
Once they are built they can be run as
 make run-test TEST=micro:BENCHMARK_TEST_NAME
Comments
[~epavlova] thanks, i can help guide, if you volunteer. Currently the unit test generation and JMH test generation are closely intertwined in the code generation script, and will need to be teased apart. Hence to some extent why the JMH tests were not already moved.
03-09-2020
I can perhaps be that volunteer if there are no other candidates ;)
02-09-2020
Because the work to transition the benchmarks over to the right place may be part of that work to integrate the benchmarks in the main repository. Until that time there is more of a chance they will stay where they are unless a kind volunteer takes over that work.
01-09-2020
> The benchmarks will not be part of the first integration and need to be reviewed under a separate follow on issue. why is it relevant here? test/jdk is a jtreg test base, meaning in a perfect world it contains only jtreg tests and/or their dependencies, micro-benchmarks are none of these things. test/micro is the "official" place for micro-benchmarks, so benchmarks in test/jdk/jdk/incubator/vector/benchmark should be moved test/micro/org/openjdk/bench/jdk/incubator/vector are updated accordingly. this will make it easier for everyone to run them. if benchmarks aren't to be integrated soon, this moving still makes sense and should be done in the corresponding branch/repo of Panama project.
01-09-2020
[~epavlova] i unassigned myself for the moment, no time right now to do any work on this. The benchmarks will not be part of the first integration and need to be reviewed under a separate follow on issue. The benchmarks are exhaustively generated, there are many, and it likely makes no sense to run 'em all regularly, some discussion is required on the scope.
01-09-2020
Hi Paul [~psandoz], Are you planning to work on this or should not be the bug be reassigned? It would be nice to be able to start running these benchmarks on regular basis in Mach5 as part of jdk16 testing once Vector API is integrated. These benchmarks will provide more functional/stress testing in addition to unit tests and as result give more confidence on Vector API functionality.
01-09-2020