JDK-8243114 : Implement montgomery{Multiply,Square}intrinsics on Windows
  • Type: Enhancement
  • Component: hotspot
  • Sub-Component: compiler
  • Affected Version: 8u102,11,14,15
  • Priority: P4
  • Status: Resolved
  • Resolution: Fixed
  • Submitted: 2020-04-18
  • Updated: 2024-11-13
  • Resolved: 2020-06-25
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 11 JDK 13 JDK 16
11.0.10-oracleFixed 13.0.6Fixed 16 b04Fixed
Related Reports
Relates :  
JDK-8130150 - Implement BigInteger.montgomeryMultiply intrinsic
Relates :  
JDK-8248347 - windows build broken by JDK-8243114
Description
It seems when JDK-8130150 was implemented, Windows paths were not implemented:
 https://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2015-June/018364.html

See:
https://hg.openjdk.java.net/jdk/jdk/file/1fa1ec0e7048/src/hotspot/cpu/x86/stubGenerator_x86_64.cpp#l6563
https://hg.openjdk.java.net/jdk/jdk/file/1fa1ec0e7048/src/hotspot/share/opto/library_call.cpp#l5154

Need to consider implementing those to avoid surprises like these:
 https://twitter.com/shipilev/status/1251591040714387456
Comments
Fix request (8u) Requesting backport to 8u for parity wth 11u and Oracle 8u. Backport is simple but must only apply if Visual Studio 2017 or higher is the build compiler due to missing intrinsic. Discussion: https://mail.openjdk.java.net/pipermail/jdk8u-dev/2021-January/013305.html webrev: http://cr.openjdk.java.net/~stooke/webrevs/jdk-8243114-jdk8u/hotspot.01/
11-01-2021
Fix request (13u) Requesting backport to 13u for parity with 11u. The patch doesn't apply cleanly due to minor context difference in stubGenerator_x86_64.cpp, reapplied manually. Tested with tier1 and jdk_security with additional options -XX:+UseMontgomeryMultiplyIntrinsic -XX:+UseMontgomerySquareIntrinsic.
11-12-2020
Fix request (11u) -- will label after testing completed. I would like to downport this for parity with 11.0.10-oracle. Applies clean.
03-09-2020
Changeset: 47e465cf Author: Andrew Haley <aph@redhat.com> Committer: Simon Tooke <stooke@openjdk.org> Date: 2020-06-25 14:19:37 +0000 URL: https://git.openjdk.java.net/amber/commit/47e465cf
02-07-2020
Changeset: 47e465cf Author: Andrew Haley <aph@redhat.com> Committer: Simon Tooke <stooke@openjdk.org> Date: 2020-06-25 14:19:37 +0000 URL: https://git.openjdk.java.net/mobile/commit/47e465cf
02-07-2020
Did this fix go thru jdk-submit testing? The Win* build has been broken by this push. See JDK-8248347 windows build broken by JDK-8243114.
25-06-2020
URL: https://hg.openjdk.java.net/jdk/jdk/rev/bf2cdc10fabe User: andrew Date: 2020-06-25 15:34:10 +0000
25-06-2020