JDK-8241122 : Remove unimplemented InlineTree constructor definition from parse.hpp
  • Type: Enhancement
  • Component: hotspot
  • Sub-Component: compiler
  • Affected Version: 11,14,15
  • Priority: P4
  • Status: Resolved
  • Resolution: Fixed
  • Submitted: 2020-03-17
  • Updated: 2020-03-24
  • Resolved: 2020-03-18
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 15
15 b15Fixed
Related Reports
Relates :  
Description
On 3/17/20 12:43 PM, Charlie Gracie wrote:
When looking through the code for InlineTree I noticed an unimplemented constructor definition. I spent a few mins looking for the
implementation and it's uses so I figure it is best to get it removed so others do not spend time as well.

I tested compilation of release, fastdebug and slowdebug builds on my Mac and also verified the JVM still starts.

Here is the patch for tip:
diff --git a/src/hotspot/share/opto/parse.hpp b/src/hotspot/share/opto/parse.hpp
index 28e440f586..adbb5ba355 100644
--- a/src/hotspot/share/opto/parse.hpp
+++ b/src/hotspot/share/opto/parse.hpp
@@ -107,9 +107,6 @@ public:
   static InlineTree* build_inline_tree_root();
   static InlineTree* find_subtree_from_root(InlineTree* root, JVMState* jvms, ciMethod* callee);
 
-  // For temporary (stack-allocated, stateless) ilts:
-  InlineTree(Compile* c, ciMethod* callee_method, JVMState* caller_jvms, float site_invoke_ratio, int max_inline_level);
-
   // See if it is OK to inline.
   // The receiver is the inline tree for the caller.
   //

Comments
URL: https://hg.openjdk.java.net/jdk/jdk/rev/86af236fbd89 User: kvn Date: 2020-03-17 21:05:39 +0000
18-03-2020

Vladimir mentions here: https://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2020-March/037506.html ...that is the leftover after JDK-8032490.
18-03-2020