JDK-8241033 : Create test library utility for getting JFR streaming repository
  • Type: Enhancement
  • Component: hotspot
  • Sub-Component: jfr
  • Affected Version: 15
  • Priority: P4
  • Status: Resolved
  • Resolution: Fixed
  • Submitted: 2020-03-13
  • Updated: 2020-03-24
  • Resolved: 2020-03-18
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 15
15 b15Fixed
Related Reports
Duplicate :  
JDK-8240710 - JFR TestCrossProcessStreaming.java failed to attach
Relates :  
JDK-8240710 - JFR TestCrossProcessStreaming.java failed to attach
Relates :  
JDK-8240622 - jfr/api/consumer/streaming/TestJVMExit.java timed out failing to attach
Description
The method to obtain JFR streaming repository for a process is replicated inside JFR testing, and also could use some improvement. Proposing the following:
  - create a unified JFR testlib method for this
  - improve it by adding logging/diagnostic info
  - use it in place of replicated test-local code

In addition to general benefits, this work will benefit the following issues:
  - 8240710: JFR TestCrossProcessStreaming.java failed to attach
  - 8240622: jfr/api/consumer/streaming/TestJVMExit.java timed out failing to attach
Comments
URL: https://hg.openjdk.java.net/jdk/jdk/rev/a6203123a1e2 User: mseledtsov Date: 2020-03-18 16:45:59 +0000
18-03-2020
Resolved in: http://hg.openjdk.java.net/jdk/jdk/rev/a6203123a1e2
18-03-2020
Webrev: http://cr.openjdk.java.net/~mseledtsov/8241033.02/ Testing: test/jdk/jdk/jfr/api/consumer/streaming/ PASS
17-03-2020
Sounds good. Thanks for taking a look. I will remove timeout handling, which will simplify the function, test and send it for review
16-03-2020
This is a good idea! By forcing tests to supply the Process, we will have information if the process is still alive when the test fails. I would remove the timeout and make it into an infinite loop. Tests that relies on timing are fragile and hard to analyze with certainty. For example, you can't rule out that the clock on the machine didn't change, or a thread was not scheduled.
14-03-2020
WebRev: http://cr.openjdk.java.net/~mseledtsov/8241033.00/ Testing: run all jfr tests (in progress)
14-03-2020