JDK-8240287 : SelectedItemsReadOnlyObservableList cleanup: remove unused code.
  • Type: Bug
  • Component: javafx
  • Sub-Component: controls
  • Priority: P4
  • Status: Closed
  • Resolution: Duplicate
  • Submitted: 2020-03-02
  • Updated: 2020-03-03
  • Resolved: 2020-03-03
Related Reports
Duplicate :  
JDK-8237926 - Potential memory leak of model data in javafx.scene.control.ListView
Relates :  
JDK-8227619 - Potential memory leak in javafx.scene.control.ListView
Relates :  
JDK-8152396 - ArrayIndexOutOfBoundsException when listening to selection changes on TreeTableView
Relates :  
JDK-8237926 - Potential memory leak of model data in javafx.scene.control.ListView
Relates :  
JDK-8154216 - Remove usage of ReadOnlyUnbackedObservableList in selection models for the selectedItems list
Description
The below member variables and a method of class SelectedItemsReadOnlyObservableList are not required anymore.
Variables: itemsList, itemsListChanged, itemsListChange, itemsListListener.
Method: setItemsList

These were added when the file was created for JDK-8154216.
But later after the fix for JDK-8152396, these class members are not required.

There are two leak issues reported for the code in question
JDK-8227619 and JDK-8237926
Comments
I recommend using the existing JBS bug, JDK-8237926, for this fix. For one thing we generally use the earlier bug unless there is a good reason not to. Also, given that this fixes a leak, the title of JDK-8237926 is more indicative of what problem is being addressed (which is usually preferred), where as the title of this bug is more about what it is being done.
02-03-2020