JDK-8240235 : jdk.test.lib.util.JarUtils updates jar files incorrectly
  • Type: Bug
  • Component: core-libs
  • Sub-Component: java.util.jar
  • Affected Version: 8,11,14,15
  • Priority: P4
  • Status: Resolved
  • Resolution: Fixed
  • Submitted: 2020-02-28
  • Updated: 2025-05-26
  • Resolved: 2020-03-03
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 11 JDK 15 JDK 8 Other
11.0.22-oracleFixed 15 b13Fixed 8u471Fixed openjdk8u452Fixed
Related Reports
Relates :  
Relates :  
Description
JarUtils.updateJar() and JarUtils.updateJarFile() update jar files by reading JarEntry-s from a source jar file and writing these exact JarEntry-s to the destination jar file follwoed be the inflated and re-deflated data belonging to this entry.

This approach is not correct, because JarEntry contains both, the compressed and uncomressed size of the corresponding entry. But the original Defalter which initially compressed that entry can be either different from the current one or it might have used a different compression level compared to the current Deflater which re-deflates the entry data. 

When the newly created entry is closed, the new compressed size will be checked against the original compressed size if that was recorded in the JarEntry and an exception will be thrown, when they differ:

java.util.zip.ZipException: invalid entry compressed size (expected 237 but got 238 bytes)
        at java.base/java.util.zip.ZipOutputStream.closeEntry(ZipOutputStream.java:267)
        at java.base/java.util.zip.ZipOutputStream.putNextEntry(ZipOutputStream.java:192)
        at java.base/java.util.jar.JarOutputStream.putNextEntry(JarOutputStream.java:108)
        at jdk.test.lib.util.JarUtils.updateJar(JarUtils.java:294)
        at jdk.test.lib.util.JarUtils.updateJar(JarUtils.java:252)
        at HasUnsignedEntryTest.start(HasUnsignedEntryTest.java:77)
        at HasUnsignedEntryTest.main(HasUnsignedEntryTest.java:44)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:
43)
        at java.base/java.lang.reflect.Method.invoke(Method.java:564)
        at com.sun.javatest.regtest.agent.MainWrapper$MainThread.run(MainWrapper.java:127)
        at java.base/java.lang.Thread.run(Thread.java:832)
        Suppressed: java.util.zip.ZipException: invalid entry compressed size (expected 237 but got 238 bytes)
                at java.base/java.util.zip.ZipOutputStream.closeEntry(ZipOutputStream.java:267)
                at java.base/java.util.zip.ZipOutputStream.finish(ZipOutputStream.java:360)
                at java.base/java.util.zip.DeflaterOutputStream.close(DeflaterOutputStream.java:237)
                at java.base/java.util.zip.ZipOutputStream.close(ZipOutputStream.java:377)
                at jdk.test.lib.util.JarUtils.updateJar(JarUtils.java:280)

The fix is trivial. Instead of copying the JarEntry-s verbatim to the output stream, simply write newly created JarEntry-s to the output stream which only contain the entry name. This is also the way how this is handled by the jar tool, when it updates jar files.
Comments
[jdk8u-fix-request] Approval Request from Roman Marchenko Fix request (jdk8u). This is needed for backporting 8309841. Applied almost cleanly, just skipped a line in an absent procedure.
26-03-2025

A pull request was submitted for review. Branch: master URL: https://git.openjdk.org/jdk8u-dev/pull/640 Date: 2025-03-24 15:21:58 +0000
24-03-2025

[jdk11u-fix-request] Approval Request from Kangcheng Xu Fix Request (jdk11u) Cleanly backported to match Oracle parity 11.0.22-oracle. Low risk for test library fixes. All tests pass on GHA.
24-10-2023

A pull request was submitted for review. URL: https://git.openjdk.org/jdk11u-dev/pull/2215 Date: 2023-10-24 16:16:44 +0000
24-10-2023

URL: https://hg.openjdk.java.net/jdk/jdk/rev/1bc5f223df65 User: simonis Date: 2020-03-03 10:25:36 +0000
03-03-2020