JDK-8239880 : CSS tests should cleanup any global state they modify
  • Type: Bug
  • Component: javafx
  • Sub-Component: controls
  • Affected Version: 8u241,openjfx14
  • Priority: P4
  • Status: Resolved
  • Resolution: Fixed
  • Submitted: 2020-02-24
  • Updated: 2022-07-07
  • Resolved: 2021-04-23
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
Other
openjfx17Fixed
Related Reports
Relates :  
JDK-8266643 - Intermittent failure of HonorDeveloperSettingsTest unit test
Relates :  
JDK-8239822 - Intermittent unit test failures in RegionCSSTest
Description
Except for the systemTests project, all unit tests are run in the same JVM, so each test class must ensure that any modified global state is restored after the tests are run. Otherwise, subsequent tests might fail as a result.

See JDK-8239822 for a case where this actually happened and caused intermittent test failures in our nightly test runs.

The following tests call StyleManager::setDefaultUserAgentStylesheet, but do not appear to restore the state:

test/javafx/css/CssMetaDataTest
test/javafx/css/HonorDeveloperSettingsTest
test/javafx/css/Node_cssStateTransition_Test
test/javafx/css/Node_cssStyleMap_Test
test/javafx/scene/Node_effectiveOrientation_Css_Test

These should be evaluated and cleaned up where needed.
Comments
Changeset: 1b407cc7 Author: Ambarish Rapte <arapte@openjdk.org> Date: 2021-04-23 02:28:20 +0000 URL: https://git.openjdk.java.net/jfx/commit/1b407cc7
23-04-2021