JDK-8236741 : Remove product_rw command line macro
  • Type: Enhancement
  • Component: hotspot
  • Sub-Component: runtime
  • Affected Version: 15
  • Priority: P4
  • Status: Resolved
  • Resolution: Duplicate
  • Submitted: 2020-01-07
  • Updated: 2020-09-11
  • Resolved: 2020-04-07
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 15
15Resolved
Related Reports
Duplicate :  
Relates :  
Description
It is unused (I couldn't find a bug for this).

// product_rw flags are writeable internal product flags.
//    They are like "manageable" flags but for internal/private use.
//    The list of product_rw flags are internal/private flags which
//    may be changed/removed in a future release.  It can be set
//    through the management interface to get/set value
//    when the name of flag is supplied.
//
//    A flag can be made as "product_rw" only if
//    - the VM implementation supports dynamic setting of the flag.
//      This implies that the VM must *always* query the flag variable
//      and not reuse state related to the flag state at any given time.
//
// Note that when there is a need to support develop flags to be writeable,
// it can be done in the same way as product_rw.

Further from [~stefank]
- The specification of product_rw is at odds with our current definition of product. product_rw are flags that are "writeable" by the managment API, but not listed by the getDiagnosticOptions() function. And, importantly, they are not supposed to be supported and can be removed any time. If we can create diagnostic, experimental, develop manageable flags this is not needed or wanted.

Comments
product_rw is removed as part of JDK-8243208, because no one uses prodict_rw today, and there's no test case for it. If you want to restore product_rw, see discussion here: https://github.com/openjdk/jdk/pull/82#discussion_r485710823
11-09-2020

Ok, I agree. The overhaul won't have product_rw though, whatever that used to mean.
13-01-2020

Please hold on the implementation as Erik O is working on an overhaul that may get rid of all the globals macros.
08-01-2020