JDK-8235728 : JDK-8212780 breaks builds with a custom X11 include path
  • Type: Bug
  • Component: tools
  • Sub-Component: jpackage
  • Affected Version: 14
  • Priority: P2
  • Status: Resolved
  • Resolution: Fixed
  • Submitted: 2019-12-10
  • Updated: 2019-12-19
  • Resolved: 2019-12-11
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 14 JDK 15
14 b27Fixed 15Fixed
Related Reports
Relates :  
JDK-8212780 - Packaging Tool Implementation
Description
src/jdk.incubator.jpackage/linux/native/libapplauncher/LinuxPlatform.h
has
#include <X11/Xlib.h>
#include <X11/Xatom.h>
but does not respect the configure flag `--x-includes`.

I'm getting
fatal error: 'X11/Xlib.h' file not found
#include <X11/Xlib.h>
         ^~~~~~~~~~~~
1 error generated
in my builds.

Maybe $(X_CFLAGS) needs to be passed somewhere in the makefiles (make/lib/Lib-jdk.incubator.jpackage.gmk)?
Comments
URL: https://hg.openjdk.java.net/jdk/jdk/rev/e279627a68e4 User: herrick Date: 2019-12-11 21:17:28 +0000
11-12-2019
Review: http://cr.openjdk.java.net/~asemenyuk/8235728/webrev.00
11-12-2019
src/make/lib/Lib-jdk.incubator.jpackage.gmk @@ -34,7 +34,7 @@ SYMBOLS_DIR := $(SUPPORT_OUTPUTDIR)/native/$(MODULE)/libapplauncher, \ TOOLCHAIN := TOOLCHAIN_LINK_CXX, \ OPTIMIZATION := LOW, \ - CFLAGS := $(CXXFLAGS_JDKLIB), \ + CFLAGS := $(CXXFLAGS_JDKLIB) $(X_CFLAGS), \ CFLAGS_windows := -EHsc -DUNICODE -D_UNICODE, \ LDFLAGS := $(LDFLAGS_JDKLIB) $(LDFLAGS_CXX_JDK) \ $(call SET_SHARED_LIBRARY_ORIGIN), \ seems to fix it in my build.
11-12-2019