JDK-8234735 : InstanceKlass:find_method_index regression after JDK-8231610
  • Type: Bug
  • Component: hotspot
  • Sub-Component: runtime
  • Affected Version: 14
  • Priority: P4
  • Status: Resolved
  • Resolution: Fixed
  • Submitted: 2019-11-25
  • Updated: 2020-01-28
  • Resolved: 2019-12-09
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 14
14 b27Fixed
Related Reports
Relates :  
Description
JDK-8231610 refactored InstanceKlass::binary_search to ::quick_search, which now has a linear slow-path version in case the VM is currently dumping the dynamic CDS archive. This cause the methods to grow enough that ::quick_search is not inlined into find_method_index, which cause a local regression.

Since the linear search is not as performance sensitive as the default binary search, then outlining the slow-path to a different method makes sense. Tests show that this allows the performance critical path to be completely inlined again, recuperating part of the performance regression (still adds a branch to check for whether we should do a linear search to the fast path)
Comments
URL: https://hg.openjdk.java.net/jdk/jdk/rev/7fbe6a42ffe9 User: redestad Date: 2019-12-09 15:43:54 +0000
09-12-2019