JDK-8234264 : Incorrect 8047434 JDK 8 backport in 8219677
  • Type: Bug
  • Component: hotspot
  • Sub-Component: runtime
  • Affected Version: openjdk8u232
  • Priority: P4
  • Status: Resolved
  • Resolution: Fixed
  • OS: generic
  • CPU: generic
  • Submitted: 2019-11-15
  • Updated: 2020-02-18
  • Resolved: 2019-12-17
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
Other
openjdk8u252 b01Fixed
Related Reports
Relates :  
JDK-8027434 - "-XX:OnOutOfMemoryError" uses fork instead of vfork
Relates :  
JDK-8219677 - "-XX:OnOutOfMemoryError" uses fork instead of vfork
Description
Reported by Felix Yang, felix.yang@huawei.com.

          The upstream patch set parameter use_vfork_if_available to true when call os::fork_and_exec in VM_ReportJavaOutOfMemory::doit().
          But looks like the 8u backport did something inconsistent: the change was not made in the correct place.
          The 8u backport patch: http://hg.openjdk.java.net/jdk8u/jdk8u/hotspot/rev/97d605522fcb

        Patch for jdk8u-dev:

        diff -r 775e2bf92114 src/share/vm/utilities/vmError.cpp
        --- a/src/share/vm/utilities/vmError.cpp        Wed Aug 07 17:00:19 2019 +0800
        +++ b/src/share/vm/utilities/vmError.cpp        Fri Nov 15 14:23:50 2019 +0800
        @@ -1060,7 +1060,7 @@
               out.print_raw   (cmd);
               out.print_raw_cr("\" ...");

        -      if (os::fork_and_exec(cmd, true) < 0) {
        +      if (os::fork_and_exec(cmd) < 0) {
                 out.print_cr("os::fork_and_exec failed: %s (%d)", strerror(errno), errno);
               }
             }
        @@ -1147,7 +1147,7 @@
        #endif
             tty->print_cr("\"%s\"...", cmd);

        -    if (os::fork_and_exec(cmd) < 0) {
        +    if (os::fork_and_exec(cmd, true) < 0) {
               tty->print_cr("os::fork_and_exec failed: %s (%d)", strerror(errno), errno);
             }
           }
Comments
URL: https://hg.openjdk.java.net/jdk8u/jdk8u/hotspot/rev/567ee384afe3 User: andrew Date: 2020-01-28 03:31:16 +0000
28-01-2020
URL: https://hg.openjdk.java.net/jdk8u/jdk8u-dev/hotspot/rev/567ee384afe3 User: phh Date: 2019-12-17 17:27:08 +0000
17-12-2019
[~phh] Actually, Volker Simonis isn't an 8u updates project Reviewer[1]. I would be happy to support getting him Reviewer status should he get proposed. Anyway, I've reviewed it as well and this should cover that bit of the process[2]. Approving for 8u. [1] http://openjdk.java.net/census#simonis [2] http://mail.openjdk.java.net/pipermail/jdk8u-dev/2019-December/010810.html
17-12-2019
Fix Request 8u. Discussion thread: https://mail.openjdk.java.net/pipermail/jdk8u-dev/2019-November/010601.html Webrev: http://cr.openjdk.java.net/~phh/8234264/webrev.8u.00/. Review approval review: https://mail.openjdk.java.net/pipermail/jdk8u-dev/2019-November/010606.html.
04-12-2019