JDK-8231124 : Missing closedir call with JDK-8223490
  • Type: Bug
  • Component: core-libs
  • Sub-Component: java.util
  • Affected Version: 14
  • Priority: P4
  • Status: Closed
  • Resolution: Fixed
  • OS: generic
  • CPU: generic
  • Submitted: 2019-09-17
  • Updated: 2022-06-27
  • Resolved: 2019-09-17
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 11 JDK 13 JDK 14 Other
11.0.6Fixed 13.0.4Fixed 14 b15Fixed openjdk8u242Fixed
Related Reports
Relates :  
JDK-8223490 - Optimize search algorithm for determining default time zone
Description
In the JDK-8223490 edits[1], line 149 means we return without closing a directory pointer allocated at line 133.

I'd prefer to just move line 133-136 down below the new fast path code in order to eliminate this issue.

[1] https://hg.openjdk.java.net/jdk/jdk/file/8ee083465318/src/java.base/unix/native/libjava/TimeZone_md.c
Comments
Fix request (13u): I'd like to port it to 13u as well. Patch applies cleanly here, in proper order after the original JDK-8223490.
22-05-2020
Fix request 8u This is a follow up for JDK-8223490. Patch was not completely clean. RFR thread was: https://mail.openjdk.java.net/pipermail/jdk8u-dev/2019-December/010720.html But thee actual review approval happened: https://mail.openjdk.java.net/pipermail/jdk8u-dev/2019-December/010733.html
10-12-2019
Fix request jdk11u This is a follow-up fix for JDK-8223490 which was backported to jdk11u. We shouldn't miss this one. Applies almost cleanly (no need to change, only hunk insertion needs to be done manually due to tiny context change from JDK-8207744).
22-11-2019
URL: https://hg.openjdk.java.net/jdk/jdk/rev/8a8e87e8a4fd User: coffeys Date: 2019-09-17 16:40:37 +0000
17-09-2019