JDK-8230184 : rename, whitespace, indent and comments changes in preparation for lock free Monitor lists
  • Type: Sub-task
  • Component: hotspot
  • Sub-Component: runtime
  • Affected Version: 14
  • Priority: P4
  • Status: Resolved
  • Resolution: Fixed
  • OS: generic
  • CPU: generic
  • Submitted: 2019-08-26
  • Updated: 2019-09-03
  • Resolved: 2019-08-28
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 14
14 b12Fixed
Related Reports
Relates :  
Description
Part of the Async Monitor Deflation project (JDK-8153224) will
be changing to lock-free Monitor list management algorithms.

A number of the variables and functions that have to be touched
in order to have lock free Monitor list management have been
commented on over the years as being in violation of the HotSpot
style guide. Since we're touching those variables and functions
anyway, we might as well rename them.

However, the renaming work would make the code review for
the lock free Monitor list management code much more difficult
so we're splitting the renaming off into a separate bug.

Along with the renaming, we're including whitespace, indent and
comment changes that are not specific to either the Async Monitor
Deflation project or lock free Monitor list management.

Update: This isn���t a complete cleanup. I started with the list variable
names and the functions that used them and added those to the
cleanup list. So if there���s a function that didn���t intersect with the
���primaries���, then I didn���t clean it up except for some globals like
���Self��� -> ���self���.

Perfect example is that ObjectMonitor.cpp isn���t touched, but
ObjectMonitor.hpp is. ObjectMonitor.cpp never touched the list
variables.
Comments
URL: https://hg.openjdk.java.net/jdk/jdk/rev/e17f768b3b71 User: dcubed Date: 2019-08-28 14:57:50 +0000
28-08-2019