JDK-8229145 : Revert TemplateTable::bytecode() visibility change
  • Type: Enhancement
  • Component: hotspot
  • Sub-Component: runtime
  • Affected Version: 8-aarch64
  • Priority: P4
  • Status: Resolved
  • Resolution: Fixed
  • Submitted: 2019-08-05
  • Updated: 2021-02-01
  • Resolved: 2019-08-06
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 8 Other
8-aarch64Fixed openjdk8u292Fixed
Related Reports
Relates :  
Description
In current 8u-aarch64 code, TemplateTable::bytecode() is public:

public:
   static Bytecodes::Code bytecode()              { return _desc->bytecode(); }
 
private:
  static BarrierSet*     _bs;                    // Cache the barrier set.

This is 8u-aarch64-specific thing, though, and 8u upstream still has it private. It seem to be added to support simulator hack in Template::generate:
https://hg.openjdk.java.net/aarch64-port/jdk8u-shenandoah/hotspot/rev/38b753943a54#l14.1

It would go away with Simulator removal. But even before that,  Template and TemplateTable are friends, so this hack is not needed. This change should be reverted.
Comments
https://hg.openjdk.java.net/aarch64-port/jdk8u-shenandoah/hotspot/rev/ec6db58f37d4
06-08-2019

RFR: https://mail.openjdk.java.net/pipermail/aarch64-port-dev/2019-August/007810.html
05-08-2019