JDK-8225137 : Clean up remaining CHECK_NULL -> THREAD return issues
  • Type: Bug
  • Component: hotspot
  • Sub-Component: runtime
  • Affected Version: openjdk8u222
  • Priority: P4
  • Status: Closed
  • Resolution: Duplicate
  • Submitted: 2019-05-31
  • Updated: 2020-10-07
  • Resolved: 2020-07-01
Related Reports
Duplicate :  
JDK-8062808 - Turn on the -Wreturn-type warning
Relates :  
JDK-8062808 - Turn on the -Wreturn-type warning
Relates :  
JDK-8064811 - Use THREAD instead of CHECK_NULL in return statements
Description
JDK-8064811 replaced uses of CHECK_NULL with THREAD in return statements. It has been backported, but there are still places in 8u where CHECK_NULL is used in a return statement. They should be fixed.
Comments
JDK-8062808 has been backported, see JDK-8254172.
07-10-2020
Removing jdk8u-fix-request as the idea, I think, is to get JDK-8062808 backported instead.
01-10-2020
When I worked on this clean-up, I realized that the upstream had fixed it. That's why I said it's subset of JDK-8062808. I suggest we close this one and just work on the backport of JDK-8062808. I will resend the code review.
30-06-2020
I don't see a reference to the review thread. Please add it and we'll consider it.
30-06-2020
It's a subset of JDK-8062808. I have requested to backport it to jdk8u. I will close this one if it is approved.
28-08-2019
Fix Request 8u. http://cr.openjdk.java.net/~phh/8225137/webrev.8u.00/
04-06-2019