JDK-8223147 : JFR Backport
  • Type: Bug
  • Component: hotspot
  • Sub-Component: jfr
  • Affected Version: openjdk8u-jfr-incubator
  • Priority: P4
  • Status: Resolved
  • Resolution: Fixed
  • Submitted: 2019-04-30
  • Updated: 2020-11-30
  • Resolved: 2019-08-14
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
Other
openjdk8u262 teamFixed
Related Reports
Blocks :  
JDK-8229366 - JFR backport allows unchecked writing to memory
CSR :  
JDK-8230764 - JFR Backport
Relates :  
JDK-8241902 - AIX Build broken after integration of JDK-8223147 (JFR Backport)
Relates :  
JDK-8257397 - [TESTBUG] test/lib/containers/docker/Common.java refers to -Xlog:os+container=trace
Relates :  
JDK-8223690 - Add JFR BiasedLock Event Support
Relates :  
JDK-8238076 - Fix OpenJDK 7 Bootstrap Broken by JFR Backport
Relates :  
JDK-8239140 - Backport JFR to OpenJDK 8
Relates :  
JDK-8223689 - Add JFR Thread Sampling Support
Relates :  
JDK-8223691 - Add JFR G1 Region Type Change Event Support
Relates :  
JDK-8223692 - Add JFR G1 Heap Summary Event Support
Relates :  
JDK-8232089 - Validate the correctness of the comments introduced by JDK-8223147
Relates :  
JDK-8246384 - Enable JFR by default on supported architectures for October 2020 release
Description
Primary bug for the backporting effort of the JFR patches from OpenJDK 11 into the OpenJDK 8 update train
Comments
I've encountered the same thing on importing the 8u262-b01 drop of Shenandoah into IcedTea. Because that HotSpot tag introduces the JFR backport, but is being used with other trees still based on 8u252-b10, ENABLE_JFR doesn't get set and the build fails. I think this is a bug (JDK-8251120) which can be easily fixed. The 8u HotSpot was meant to work independently of the autoconf system and the JFR changes break this.
04-08-2020
Problem is that I'm on a Mac and JDK8 is not buildable on the current macOS: sh configure ... checking for xcodebuild... /usr/bin/xcodebuild configure: error: Xcode 4 is required to build JDK 8, the version found was 11.3. Use --with-xcode-path to specify the location of Xcode 4 or make Xcode 4 active by using xcode-select. configure exiting with result code 1 I discovered this by trying to build graal-jvmci-8 after merging in the jdk8u262-ga changes. If I don't set ENABLE_JFR=true on the make command line, I get errors such as the one in my comment above. Could well be an error resulting from the merge so let me investigate further before paying any more attention to this.
16-07-2020
When merging the hotspot part of this backport into https://github.com/graalvm/graal-jvmci-8, it appears as though it fails to build unless ENABLE_JFR=true. I get errors such as: In file included from /Users/dnsimon/graal/graal-jvmci-8/src/share/vm/jfr/leakprofiler/checkpoint/eventEmitter.cpp:31: /Users/dnsimon/graal/graal-jvmci-8/src/share/vm/jfr/leakprofiler/sampling/objectSample.hpp:211:24: error: no member named 'ft_value' in 'TimeInstant<CounterRepresentation, ElapsedCounterSource>' _allocation_time.ft_value() : _allocation_time.value()) < time_stamp; ~~~~~~~~~~~~~~~~ ^ Before filing a bug about this, I just wanted to ask if hotspot should still be buildable when ENABLE_JFR=false.
16-07-2020
It should. The default build of OpenJDK 8u262 (just released) has JFR disabled and I've built this successfully several times. So I'd be interested to know how this is failing for you.
16-07-2020
URL: https://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/7c0427079f10 User: andrew Date: 2020-03-03 13:25:45 +0000
03-03-2020
URL: https://hg.openjdk.java.net/jdk8u/jdk8u-dev/hotspot/rev/b985cbb00e68 User: andrew Date: 2020-03-03 13:25:31 +0000
03-03-2020
URL: https://hg.openjdk.java.net/jdk8u/jdk8u-dev/rev/e86abea74e04 User: andrew Date: 2020-03-03 13:24:51 +0000
03-03-2020
Replacing jdk8u-fix-request with link to JDK-8239140
17-02-2020
RFC: https://mail.openjdk.java.net/pipermail/jdk8u-dev/2020-January/011063.html
30-01-2020
Excellent!
21-05-2019
just in case, webrev link is http://cr.openjdk.java.net/~apetushkov/8223147/
21-05-2019
webrevs are ready. will publish RFR tomorrow, May 7
06-05-2019
What is the ETA for this effort?
06-05-2019