JDK-8222934 : mark new VM option AllowRedefinitionToAddOrDeleteMethods as deprecated
  • Type: Bug
  • Component: hotspot
  • Sub-Component: jvmti
  • Affected Version: 13
  • Priority: P4
  • Status: Resolved
  • Resolution: Fixed
  • Submitted: 2019-04-24
  • Updated: 2019-05-02
  • Resolved: 2019-04-30
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 13
13 b19Fixed
Related Reports
Relates :  
JDK-8192936 - RI does not follow the JVMTI RedefineClasses spec that is too strict in the definition
Description
In review of 8192936 David suggested:

Three minor comments:
1. I would have suggested to add "(Deprecated)" to the description of the new flag in globals.hpp
2. The new flag should have been added to the deprecated VM options tests.
3. The new test should run in both a positive and negative mode so that it also checks that the new flag works.
Comments
The suggested fix is: diff -r 3452d108d06d src/hotspot/share/runtime/globals.hpp --- a/src/hotspot/share/runtime/globals.hpp Fri Apr 19 21:49:54 2019 -0700 +++ b/src/hotspot/share/runtime/globals.hpp Wed Apr 24 10:55:52 2019 -0700 @@ -979,8 +979,8 @@ "Verify bytecodes after RedefineClasses constant pool merging") \ \ product(bool, AllowRedefinitionToAddDeleteMethods, false, \ - "Allow redefinition to add and delete private static or " \ - "final methods for compatibility with old releases") \ + "(Deprecated) Allow redefinition to add and delete private " \ + "static or final methods for compatibility with old releases") \ \ develop(bool, TraceBytecodes, false, \ "Trace bytecode execution") \ Also, new test has to be updated to work with new option as well: test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/TestAddDeleteMethods.java
24-04-2019