JDK-8222295 : more baseline cleanups from Async Monitor Deflation project
  • Type: Sub-task
  • Component: hotspot
  • Sub-Component: runtime
  • Affected Version: 13
  • Priority: P4
  • Status: Resolved
  • Resolution: Fixed
  • OS: generic
  • CPU: generic
  • Submitted: 2019-04-10
  • Updated: 2019-08-15
  • Resolved: 2019-04-24
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 13
13 b18Fixed
Description
This sub-task captures updates to the baseline code that came up
during the Async Monitor Deflation project design review and code
review email threads.
 
The cleanups include:

- rename ObjectMonitor::_count -> ObjectMonitor::_contentions
- update comment in objectMonitor.hpp for _contentions field declaration
- delete unused count_offset_in_bytes()
- delete count() getter
- replace uses of 'count()' with 'contentions()'
- deleted declared but undefined set_count()
- delete some stale TODO-FIXME comments
- update comments in ObjectSynchronizer::FastHashCode()
- change 'hashcode' -> 'hash code' for consistency; the consistent
  forms are: 'hash code', 'Hash Code', 'hashCode' and 'HashCode'
- add more assert() diagnostics for incoming object header in inflate()
- add more assert() diagnostics for enter()'s TrySpin() branch
- add more assert() diagnostics in ObjectMonitor::clear()
- add more assert() and guarantee() diagnostics in
  ObjectSynchronizer::deflate_monitor()
- get rid of unnecessary '(address)' casts

One of the changes is in print output:

-      st->print("{count=0x%08x,waiters=0x%08x"
+      st->print("{contentions=0x%08x,waiters=0x%08x"

I searched for tests that depended on '{count=.*,waiters=' and did not find any.