JDK-8216351 : Missing since information in deprecation of constructor visitors
  • Type: CSR
  • Component: core-libs
  • Sub-Component: javax.lang.model
  • Priority: P3
  • Status: Closed
  • Resolution: Approved
  • Fix Versions: 12
  • Submitted: 2019-01-08
  • Updated: 2019-01-09
  • Resolved: 2019-01-09
Related Reports
CSR :  
Description
Summary
-------

Add the "since" information that was omitted in the Deprecated annotations added to `javax.lang.model.util` under JDK-8173606.

Problem
-------

The "since" information was omitted in the Deprecated annotations added to `javax.lang.model.util` under JDK-8173606.

Solution
--------

Add the information in question.

Specification
-------------

    --- old/src/java.compiler/share/classes/javax/lang/model/util/AbstractAnnotationValueVisitor7.java	2019-01-07 23:13:31.340000000 -0800
    +++ new/src/java.compiler/share/classes/javax/lang/model/util/AbstractAnnotationValueVisitor7.java	2019-01-07 23:13:31.140000000 -0800
    @@ -68,7 +68,7 @@
          * @deprecated Release 7 is obsolete; update to a visitor for a newer
          * release level.
          */
    -    @Deprecated
    +    @Deprecated(since="12")
         protected AbstractAnnotationValueVisitor7() {
             super(); // Superclass constructor deprecated too
         }
    --- old/src/java.compiler/share/classes/javax/lang/model/util/AbstractElementVisitor7.java	2019-01-07 23:13:31.780000000 -0800
    +++ new/src/java.compiler/share/classes/javax/lang/model/util/AbstractElementVisitor7.java	2019-01-07 23:13:31.584000000 -0800
    @@ -71,7 +71,7 @@
          * @deprecated Release 7 is obsolete; update to a visitor for a newer
          * release level.
          */
    -    @Deprecated
    +    @Deprecated(since="12")
         protected AbstractElementVisitor7(){
             super(); // Superclass constructor deprecated too
         }
    --- old/src/java.compiler/share/classes/javax/lang/model/util/AbstractTypeVisitor7.java	2019-01-07 23:13:32.196000000 -0800
    +++ new/src/java.compiler/share/classes/javax/lang/model/util/AbstractTypeVisitor7.java	2019-01-07 23:13:32.000000000 -0800
    @@ -71,7 +71,7 @@
          * @deprecated Release 7 is obsolete; update to a visitor for a newer
          * release level.
          */
    -    @Deprecated
    +    @Deprecated(since="12")
         protected AbstractTypeVisitor7() {
             super();  // Superclass constructor deprecated too
         }
    --- old/src/java.compiler/share/classes/javax/lang/model/util/ElementKindVisitor7.java	2019-01-07 23:13:32.620000000 -0800
    +++ new/src/java.compiler/share/classes/javax/lang/model/util/ElementKindVisitor7.java	2019-01-07 23:13:32.428000000 -0800
    @@ -85,7 +85,7 @@
          * @deprecated Release 7 is obsolete; update to a visitor for a newer
          * release level.
          */
    -    @Deprecated
    +    @Deprecated(since="12")
         protected ElementKindVisitor7() {
             super(null); // Superclass constructor deprecated too
         }
    @@ -99,7 +99,7 @@
          * @deprecated Release 7 is obsolete; update to a visitor for a newer
          * release level.
          */
    -    @Deprecated
    +    @Deprecated(since="12")
         protected ElementKindVisitor7(R defaultValue) {
             super(defaultValue); // Superclass constructor deprecated too
         }
    --- old/src/java.compiler/share/classes/javax/lang/model/util/ElementScanner7.java	2019-01-07 23:13:33.028000000 -0800
    +++ new/src/java.compiler/share/classes/javax/lang/model/util/ElementScanner7.java	2019-01-07 23:13:32.836000000 -0800
    @@ -98,7 +98,7 @@
          * @deprecated Release 7 is obsolete; update to a visitor for a newer
          * release level.
          */
    -    @Deprecated
    +    @Deprecated(since="12")
         protected ElementScanner7(){
             super(null); // Superclass constructor deprecated too
         }
    @@ -112,7 +112,7 @@
          * @deprecated Release 7 is obsolete; update to a visitor for a newer
          * release level.
          */
    -    @Deprecated
    +    @Deprecated(since="12")
         protected ElementScanner7(R defaultValue){
             super(defaultValue); // Superclass constructor deprecated too
         }
    --- old/src/java.compiler/share/classes/javax/lang/model/util/SimpleAnnotationValueVisitor7.java	2019-01-07 23:13:33.432000000 -0800
    +++ new/src/java.compiler/share/classes/javax/lang/model/util/SimpleAnnotationValueVisitor7.java	2019-01-07 23:13:33.240000000 -0800
    @@ -75,7 +75,7 @@
          * @deprecated Release 7 is obsolete; update to a visitor for a newer
          * release level.
          */
    -    @Deprecated
    +    @Deprecated(since="12")
         protected SimpleAnnotationValueVisitor7() {
             super(null); // Superclass constructor deprecated too
         }
    @@ -89,7 +89,7 @@
          * @deprecated Release 7 is obsolete; update to a visitor for a newer
          * release level.
          */
    -    @Deprecated
    +    @Deprecated(since="12")
         protected SimpleAnnotationValueVisitor7(R defaultValue) {
             super(defaultValue); // Superclass constructor deprecated too
         }
    --- old/src/java.compiler/share/classes/javax/lang/model/util/SimpleElementVisitor7.java	2019-01-07 23:13:33.840000000 -0800
    +++ new/src/java.compiler/share/classes/javax/lang/model/util/SimpleElementVisitor7.java	2019-01-07 23:13:33.644000000 -0800
    @@ -81,7 +81,7 @@
          * @deprecated Release 7 is obsolete; update to a visitor for a newer
          * release level.
          */
    -    @Deprecated
    +    @Deprecated(since="12")
         protected SimpleElementVisitor7(){
             super(null); // Superclass constructor deprecated too
         }
    @@ -95,7 +95,7 @@
          * @deprecated Release 7 is obsolete; update to a visitor for a newer
          * release level.
          */
    -    @Deprecated
    +    @Deprecated(since="12")
         protected SimpleElementVisitor7(R defaultValue){
             super(defaultValue); // Superclass constructor deprecated too
         }
    --- old/src/java.compiler/share/classes/javax/lang/model/util/SimpleTypeVisitor7.java	2019-01-07 23:13:34.252000000 -0800
    +++ new/src/java.compiler/share/classes/javax/lang/model/util/SimpleTypeVisitor7.java	2019-01-07 23:13:34.060000000 -0800
    @@ -81,7 +81,7 @@
          * @deprecated Release 7 is obsolete; update to a visitor for a newer
          * release level.
          */
    -    @Deprecated
    +    @Deprecated(since="12")
         protected SimpleTypeVisitor7(){
             super(null); // Superclass constructor deprecated too
         }
    @@ -95,7 +95,7 @@
          * @deprecated Release 7 is obsolete; update to a visitor for a newer
          * release level.
          */
    -    @Deprecated
    +    @Deprecated(since="12")
         protected SimpleTypeVisitor7(R defaultValue){
             super(defaultValue); // Superclass constructor deprecated too
         }
    --- old/src/java.compiler/share/classes/javax/lang/model/util/TypeKindVisitor7.java	2019-01-07 23:13:34.668000000 -0800
    +++ new/src/java.compiler/share/classes/javax/lang/model/util/TypeKindVisitor7.java	2019-01-07 23:13:34.476000000 -0800
    @@ -82,7 +82,7 @@
          * @deprecated Release 7 is obsolete; update to a visitor for a newer
          * release level.
          */
    -    @Deprecated
    +    @Deprecated(since="12")
         protected TypeKindVisitor7() {
             super(null); // Superclass constructor deprecated too
         }
    @@ -96,7 +96,7 @@
          * @deprecated Release 7 is obsolete; update to a visitor for a newer
          * release level.
          */
    -    @Deprecated
    +    @Deprecated(since="12")
         protected TypeKindVisitor7(R defaultValue) {
             super(defaultValue); // Superclass constructor deprecated too
         }



Comments
Moving to Approved.
09-01-2019