JDK-8215687 : [Graal] unit test CheckGraalIntrinsics failed after 8212043
  • Type: Bug
  • Component: hotspot
  • Sub-Component: compiler
  • Affected Version: 11.0.11,13
  • Priority: P2
  • Status: Resolved
  • Resolution: Fixed
  • OS: generic
  • CPU: generic
  • Submitted: 2018-12-19
  • Updated: 2021-04-23
  • Resolved: 2018-12-20
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 11 JDK 13
11.0.11Fixed 13 b02Fixed
Related Reports
Relates :  
JDK-8212043 - AArch64: Add floating-point Math.min/max intrinsics
Relates :  
JDK-8215728 - [Graal] we should run some Graal tests in tier1
Description
JDK-8212043 added new intrinsics. Graal test should be adjusted to new intrinsics.
This is similar to  JDK-8215317.

In addition to test fix I suggest to add this Graal test to Tier-1 testing so that "submit" testing can catch this failure.
Comments
Fix Request (11u): This test fix is required for backporting of JDK-8212043. The patch does not apply cleanly because of different neighbor elements, and exclusions should be added for JDK 11+ instead of JDK 13+. 11u RFR is in JDK-8212043 thread: https://mail.openjdk.java.net/pipermail/jdk-updates-dev/2021-January/004734.html http://cr.openjdk.java.net/~dchuyko/8215687/webrev.11u.00/
25-01-2021
http://cr.openjdk.java.net/~kvn/8215687/webrev.00/
20-12-2018
Next intrinsics have to be added to checks in CheckGraalIntrinsics.java test: java/lang/Math.max(DD)D java/lang/Math.max(FF)F java/lang/Math.min(DD)D java/lang/Math.min(FF)F
20-12-2018
I created RFE JDK-8215728 to add some Graal tests into tier1 testing.
20-12-2018
Yes, as with JDK-8215317 the fix could be pushed into JDK first and then file PR for Graal repo.
20-12-2018
This test can NOT be failing all the way to the next Graal update. It has been open for too long already. Please push the fix to jdk/jdk or problemlist the test asap.
20-12-2018
[~iignatyev] Igor, from what I see in mach5 the job running graal unit tests it could take from ~10 mins to ~18 mins, depends on machine and platform.
20-12-2018
[~iignatyev] #time mx unittest [skip] real 6m43.456s user 16m50.168s sys 0m20.649s
20-12-2018
[~kvn] Vladimir: how would you like this to proceed? I'd like to see fixed in jdk/jdk ASAP or else added to ProblemList.
20-12-2018
Sorry for the introducing this failure. I know that JDK-8212043 would break this test. I just supposed that the fix should be submitted to Graal repo as JDK-8212043 is target for JDK13 so this failure will be fixed after the Graal sync next time. So my question is should the fix be submitted to jdk/jdk, github or both?
20-12-2018
how long does it take to run all graal unit tests?
20-12-2018
[~epavlova] Katya, can we run just this one unit CheckGraalIntrinsics test and may be few others small one (total under 2 min) in Tier-1?
20-12-2018