JDK-8214329 : SwingMark SubMenus 9% regression in 12-b19 on Linux client
  • Type: Bug
  • Component: security-libs
  • Sub-Component: java.security
  • Affected Version: 12
  • Priority: P3
  • Status: Resolved
  • Resolution: Fixed
  • OS: linux
  • Submitted: 2018-11-26
  • Updated: 2024-04-15
  • Resolved: 2018-12-18
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 11 JDK 12 JDK 13
11.0.21.0.0.1-oracleFixed 12 b25Fixed 13Fixed
Related Reports
Blocks :  
JDK-8215205 - javaVFrame much slower than vframeStream
Relates :  
JDK-8215521 - add microbenchmark to measure AccessController.getContext
Relates :  
JDK-8212605 - Pure-Java implementation of AccessController.doPrivileged
Description
In "8212605: Pure-Java implementation of AccessController.doPrivileged", the stackwalk in JVM_GetStackAccessControlContext was changed from using a vframeStream to using a javaVFrame, so that it could access locals. However this caused a regression because javaVFrame has more overhead. JDK-8215205 fixes the problem by allowing the use of javaVFrame only when needed.

This change reverts JVM_GetStackAccessControlContext back to using vframeStream, and uses the new API in JDK-8215205 to get a javaVFrame lazily.  It also removes two unnecessary calls to java_sender().
Comments
URL: http://hg.openjdk.java.net/jdk/jdk12/rev/a7bd89486175 User: dlong Date: 2018-12-18 20:58:22 +0000
18-12-2018
Eric, I don't expect my other fix to increase performance. How do I interpret the profiles data? Does it show hot spots or problem areas?
09-12-2018
[~dlong] Hi Dean, Sean told me you have a further fix related to the all Java access control, should we re-test this when that is done?
07-12-2018
The java implementation of AccessController.doPrivileged is a big win on the other apps we tested but causes a regression here. I will profile this more and try to see what is happening.
29-11-2018
I can reproduce this on my local WS at least once, I will try to find it.
28-11-2018
There is no client commit in jdk12b19. https://bugs.openjdk.java.net/issues/?jql=project%20%3D%20JDK%20AND%20resolution%20%3D%20Fixed%20AND%20fixVersion%20%3D%20%2212%22%20AND%20component%20%3D%20client-libs%20AND%20%22Resolved%20In%20Build%22%20%3D%20b19%20ORDER%20BY%20assignee%20ASC%2C%20priority%20DESC%2C%20key%20DESC Commits are from hotspot and core and seems more likely this bug fix from compiler may have caused this issue : JDK-8198294
28-11-2018