JDK-8211977 : move testlibrary tests into one place
  • Type: Sub-task
  • Component: other-libs
  • Sub-Component: other
  • Affected Version: 12
  • Priority: P4
  • Status: Resolved
  • Resolution: Fixed
  • Submitted: 2018-10-10
  • Updated: 2024-10-17
  • Resolved: 2020-06-16
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 15 JDK 16
15 b28Fixed 16Fixed
Related Reports
Relates :  
JDK-8247725 - move two tests for whitebox from test/hotspot/jtreg/sanity to test/lib-test
Relates :  
JDK-8189400 - testlibrary_tests are not tested in hotspot tiers
Description
- test/jdk/lib/testlibrary/AssertsTest.java, OutputAnalyzerReportingTest.java, and OutputAnalyzerTest.java are tests for some of the test library classes
- test/hotspot/jtreg/testlibrary_tests also contains number of tests for top-level testlibrary

suggest moving to a one test library test dir -- /test/lib-test/.
Comments
Changeset: e7f8e1fd Author: Igor Ignatyev <iignatyev@openjdk.org> Date: 2020-06-16 09:50:45 +0000 URL: https://git.openjdk.java.net/lanai/commit/e7f8e1fd
02-07-2020
Changeset: e7f8e1fd Author: Igor Ignatyev <iignatyev@openjdk.org> Date: 2020-06-16 09:50:45 +0000 URL: https://git.openjdk.java.net/panama-foreign/commit/e7f8e1fd
02-07-2020
Changeset: e7f8e1fd Author: Igor Ignatyev <iignatyev@openjdk.org> Date: 2020-06-16 09:50:45 +0000 URL: https://git.openjdk.java.net/amber/commit/e7f8e1fd
02-07-2020
URL: https://hg.openjdk.java.net/jdk/jdk15/rev/9f4cf92a95ab User: iignatyev Date: 2020-06-16 16:52:38 +0000
16-06-2020
http://cr.openjdk.java.net/~iignatyev//8211977/webrev.02
16-06-2020
https://mail.openjdk.java.net/pipermail/hotspot-dev/2020-June/042099.html
13-06-2020
http://cr.openjdk.java.net/~iignatyev//8211977/webrev.00/ besides moving tests from test/jdk/lib/testlibrary and test/hotspot/jtreg/testlibrary_tests to test/lib-test the patch also - problem lists HexPrinterTest.java on windows due to JDK-8247521 - introduces make targets to build native parts for the tests in test/lib-test (needed b/c one test has a native part) - adds randomness k/w to test/lib-test (as it's used by RandomGeneratorTest.java) - makes Test class used by TestNativeProcessBuilder a static nested class of TestNativeProcessBuilder - updates LingeredAppTest to use @build instead of @compile and adds necessary @library tag - removes AssertsTest.java, OutputAnalyzerTest.java from test/hotspot/jtreg/testlibrary_tests as they are either identical or lesser that the same tests from test/jdk/lib/testlibrary/ - merges test/hotspot/jtreg/testlibrary_tests/OutputAnalyzerTest.java and test/jdk/lib/testlibrary/OutputAnalyzerTest.java (effectively adds test cases for `firstMatch` to the superier copy from test/jdk/lib/testlibrary)
13-06-2020
AssertsTest.java, OutputAnalyzerTest.java, OutputAnalyzerReportingTest.java tests exist in both jdk and hotspot test suites and obviously are not identical.
12-06-2020