Bug ID: JDK-8211228 Zero build is broken after JDK-8196341 (Add JFR events for parallel phases of G1)

JDK-8211228 : Zero build is broken after JDK-8196341 (Add JFR events for parallel phases of G1)

Type: Bug
Component: hotspot
Sub-Component: gc

Priority: P4
Status: Closed
Resolution: Duplicate

Submitted: 2018-09-27
Updated: 2018-09-27
Resolved: 2018-09-27

Related Reports

Duplicate :	JDK-8211239 - Build fails without JFR: empty JFR events signatures mismatch
Relates :	JDK-8211239 - Build fails without JFR: empty JFR events signatures mismatch
Relates :	JDK-8196341 - Add JFR events for parallel phases of G1
Relates :	JDK-8211213 - AIX build fails after 8196341: Add JFR events for parallel phases of G1

Description

Zero x86_64:

/pool/buildbot/slaves/sobornost/jdkX/build/src/hotspot/share/gc/g1/g1CollectedHeap.cpp: In member function 'bool G1ParEvacuateFollowersClosure::offer_termination()':
/pool/buildbot/slaves/sobornost/jdkX/build/src/hotspot/share/gc/g1/g1CollectedHeap.cpp:3177:106: error: no matching function for call to 'EventGCPhaseParallel::commit(uint, uint, const char*)'
   event.commit(GCId::current(), pss->worker_id(), G1GCPhaseTimes::phase_name(G1GCPhaseTimes::Termination));
                                                                                                          ^

Comments

Real fix should be done in JDK-8211239.
27-09-2018
RFR: http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/2018-September/023345.html
27-09-2018
I think Zero just does not have JFR enabled, but still builds with G1. So we want to protect the JFR paths with JFR_ONLY. I have a patch that does it.
27-09-2018
Webrev: http://cr.openjdk.java.net/~shade/8211228/webrev.01/
27-09-2018
Could that be the same as JDK-8211213? This would indicate for that issue that there is something wrong with the code, and not with the compiler (I am assuming you are using some GCC version).
27-09-2018