JDK-8210912 : Build error in src/jdk.crypto.cryptoki/share/native/libj2pkcs11/p11_convert.c after JDK-8029661
  • Type: Bug
  • Component: security-libs
  • Sub-Component: javax.crypto
  • Affected Version: 12
  • Priority: P1
  • Status: Closed
  • Resolution: Fixed
  • OS: solaris
  • CPU: sparc_64
  • Submitted: 2018-09-19
  • Updated: 2018-12-18
  • Resolved: 2018-09-19
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 11 JDK 12
11.0.3-oracleFixed 12 b12Fixed
Related Reports
Relates :  
JDK-8029661 - Support TLS v1.2 algorithm in SunPKCS11 provider
Description
* For target support_native_jdk.crypto.cryptoki_libj2pkcs11_p11_convert.o:
"src/jdk.crypto.cryptoki/share/native/libj2pkcs11/p11_convert.c", line 527: error: declaration can not follow a statement (E_DECLARATION_IN_CODE)
"src/jdk.crypto.cryptoki/share/native/libj2pkcs11/p11_convert.c", line 550: error: declaration can not follow a statement (E_DECLARATION_IN_CODE)
"src/jdk.crypto.cryptoki/share/native/libj2pkcs11/p11_convert.c", line 556: error: declaration can not follow a statement (E_DECLARATION_IN_CODE)
"src/jdk.crypto.cryptoki/share/native/libj2pkcs11/p11_convert.c", line 797: error: declaration can not follow a statement (E_DECLARATION_IN_CODE)
"src/jdk.crypto.cryptoki/share/native/libj2pkcs11/p11_convert.c", line 820: error: declaration can not follow a statement (E_DECLARATION_IN_CODE)
"src/jdk.crypto.cryptoki/share/native/libj2pkcs11/p11_convert.c", line 827: error: declaration can not follow a statement (E_DECLARATION_IN_CODE)
cc: acomp failed for src/jdk.crypto.cryptoki/share/native/libj2pkcs11/p11_convert.c
Comments
Fix request Needed to go in with already approved JDK-8029661
04-12-2018
SPARC builds passed in my verification job, so I will send the change out for review.
19-09-2018
Running a verification job now.
19-09-2018
Fix looks good to me. Are you able to test it? I don't have a sparc_64 testing environment unfortunately. I wonder why this was not triggered when testing through the JDK-submit repo. Isn't sparc_64 built there?
19-09-2018
Potential fix (completely untested): http://cr.openjdk.java.net/~mikael/webrevs/8210912/webrev.00/open/webrev/
19-09-2018
[~mbalao] I just realized that this is SPARC and you may not be able to easily develop and test a fix.
19-09-2018