JDK-8210112 : remove jdk.testlibrary.ProcessTools
  • Type: Sub-task
  • Component: other-libs
  • Sub-Component: other
  • Affected Version: 10,12
  • Priority: P4
  • Status: Resolved
  • Resolution: Fixed
  • Submitted: 2018-08-28
  • Updated: 2022-03-29
  • Resolved: 2018-09-07
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 11 JDK 12
11.0.16Fixed 12 b11Fixed
Related Reports
Duplicate :  
JDK-8187806 - executeTestJava handles -cp differently in jdk.test.lib.process.ProcessTools and jdk.testlibrary.ProcessTools
Comments
A pull request was submitted for review. URL: https://git.openjdk.java.net/jdk11u-dev/pull/945 Date: 2022-03-25 07:12:36 +0000
25-03-2022
Fix request [11u] I backport this to simplify follow-up backports. No risk, only a test change. SAP nighlty testing passed.
25-03-2022
Git URL: https://github.com/openjdk/jdk/commit/21a0458422c462f5ae82a98ce08c6460db26c67e
10-03-2022
URL: http://hg.openjdk.java.net/jdk/jdk/rev/b487c1e914d0 User: iignatyev Date: 2018-09-07 21:23:45 +0000
07-09-2018
I skimmed through the test/jdk/* changes in webrev.00 and they look okay. For the code review then it would be good to point out any code changes in the tests that aren't changes to jtreg tags or imports. One question you may be asked about is the removal of ProcessTools from the build tag, esp. in tests where it explicitly compiles other test infrastructure. On the test infra changes then having shouldXXX methods return a line count is a bit strange. It would be good to explore alternative names for some of these methods. If these method do throw exceptions (as the implementation suggests) then it would be good to get them into the javadoc to make it easier for those writing tests.
30-08-2018
http://cr.openjdk.java.net/~iignatyev//8210112/webrev.00/index.html
29-08-2018