JDK-8209657 : Refactor filemap.hpp to simplify integration with Serviceability Agent
  • Type: Bug
  • Component: hotspot
  • Sub-Component: runtime
  • Priority: P3
  • Status: Resolved
  • Resolution: Fixed
  • Submitted: 2018-08-17
  • Updated: 2019-12-10
  • Resolved: 2018-08-22
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 11 JDK 12
11.0.7Fixed 12 b09Fixed
Related Reports
Relates :  
Relates :  
Description
The FileMapHeader type declaration is duplicated between HotSpot (in filemap.hpp) and Serviceability Agent (in the following 3 files)

http://hg.openjdk.java.net/jdk/jdk/file/d9f6e3ee7fcb/src/jdk.hotspot.agent/linux/native/libsaproc/ps_core.c#l224
http://hg.openjdk.java.net/jdk/jdk/file/d9f6e3ee7fcb/src/jdk.hotspot.agent/solaris/native/libsaproc/saproc.cpp#l508
http://hg.openjdk.java.net/jdk/jdk/file/d9f6e3ee7fcb/src/jdk.hotspot.agent/macosx/native/libsaproc/ps_core.c#l226

SA uses only a small portion of FileMapHeader. We should move that into a common header file to avoid the code duplication.
Comments
RFR has been sent to OpenJDK mailing lists for the backport: https://mail.openjdk.java.net/pipermail/jdk-updates-dev/2019-October/001973.html
03-10-2019