JDK-8207267 : Enable tests which currently do not run with Java Graal to run with libgraal
  • Type: Sub-task
  • Component: hotspot
  • Sub-Component: compiler
  • Affected Version: 12
  • Priority: P4
  • Status: Open
  • Resolution: Unresolved
  • OS: generic
  • CPU: generic
  • Submitted: 2018-07-13
  • Updated: 2020-09-24
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
Other
tbdUnresolved
Related Reports
Duplicate :  
JDK-8222524 - [Graal] Execution is very slow with -Xcomp and -XX:-TieredCompilation
Duplicate :  
JDK-8204347 - [Graal] compiler/stable/* tests fail with java.lang.AssertionError
Duplicate :  
JDK-8230419 - [Graal] serviceability/sa/ClhsdbInspect.java fails with Graal
Duplicate :  
JDK-8181833 - [Graal] UnsafeGetStableArrayElement.java fails with "assertNotEquals: expected 1 to not equal 1"
Duplicate :  
JDK-8201333 - [Graal] compiler/jvmci/compilerToVM/ReprofileTest.java fails when running with Graal as JIT
Duplicate :  
JDK-8244656 - serviceability/sa/ClhsdbJstackXcompStress.java times out with Graal
Relates :  
JDK-8196611 - [Graal] Tests unaware of objects allocation triggered by Graal
Relates :  
JDK-8222417 - compiler/loopopts/TestOverunrolling.java times out
Relates :  
JDK-8223445 - compiler/intrinsics/mathexact/LongMulOverflowTest.java java timeout
Relates :  
JDK-8223380 - [Graal] compiler/c2/Test8062950.java failed with time out.
Relates :  
JDK-8222418 - compiler/arguments/TestScavengeRootsInCode.java times out
Description
Currently we have a lot of tests guarded by @requires !vm.graal.enabled to avoid running with Java Graal because known issues: affects on Java heap, slow startup, timeouts when Tiered compilation is of (Graal have to compile itself).
We should make sure to be able run all these test with libgraal.so which should not have these issues.
vm.graal.enabled should be false in libgraal.so case. May be rename vm.graal.enabled to vm.javagraal.enabled to distinguish Graal run as Java application in Hotspot vs libgraal.so
Comments
These tests are also failing with Graal/JVMCI: compiler/unsafe/UnsafeGetConstantField.java compiler/uncommontrap/DeoptReallocFailure.java serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorTest.java serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorMultiArrayTest.java serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorGCSerialTest.javaserviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorGCParallelTest.javaserviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorEventOnOffTest.java serviceability/sa/ClhsdbInspect.java Should I file separate bugs or will they go on the problem list under this bug ID? I see that HeapMonitorMultiArrayTest.java is already on ProblemList-graal.txt for "8196611 generic-all", but it is still getting run with I add -XX:+UseJVMCICompiler on the command-line. Is ProblemList-graal.txt only used when Graal is enabled using a special tier?
24-09-2020
should we close other similar bugs (e.g. JDK-8196611) as duplicates of this one and update the problem-list file accordingly?
17-11-2019
Agree. Maintain a list is easier. My main point was that @requires !vm.graal.enabled should not be used for libgraal.so by default. Regarding intrinsics - Graal have to support all intrinisics (and most optimizations) which C2 has. The list should be small.
25-07-2018
some of tests w/ @requires !vm.graal.enabled won't be applicable for libgraal.so scenario as well, e.g. tests for compiler-specific intrinsics. I suggest that we put tests which fail w/ java graal and are supposed to work fine w/ libgraal to graal specific problem list instead of adding a new property to requires context.
25-07-2018