JDK-8201553 : Update FX build to use gradle 4.8
  • Type: Bug
  • Component: javafx
  • Sub-Component: build
  • Affected Version: openjfx11
  • Priority: P2
  • Status: Resolved
  • Resolution: Fixed
  • Submitted: 2018-04-13
  • Updated: 2020-01-31
  • Resolved: 2018-06-07
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 8 Other
8u201Fixed openjfx11Fixed
Related Reports
Blocks :  
JDK-8209967 - Bump minimum gradle version to 4.8 for JDK 11
Blocks :  
JDK-8199071 - Fix gradle deprecation warnings
Blocks :  
JDK-8200446 - Update minimum boot JDK to 10
Duplicate :  
JDK-8155051 - Improve test system usability for doing a single test run
Duplicate :  
JDK-8199069 - Cannot build FX with JDK 11
Description
In order to be able to build FX using JDK 11, we will need to start using gradle 4.8 once it is released. This will include updating gradle wrapper to use 4.8.

We currently use gradle 4.3, which has only limited support for JDK 10 and fails completely when run with JDK 11.
Comments
+1 from me. -phil.
31-08-2018
lgtm.
31-08-2018
Backport to 8u-dev ------------------- Webrev: http://cr.openjdk.java.net/~kcr/8201553/8u/webrev.00/ Currently, FX 8u is built using gradle 1.8, although it is known to work for developer builds using gradle 3.x. It fails to build with gradle 4.x due to various changes in gradle. The 8u backport is a combination of changes from: JDK-8201553 Update FX build to use gradle 4.8 (this bug) JDK-8199071 Fix gradle deprecation warnings (so that it is buildable with gradle 4.x) JDK-8209967 Bump minimum gradle version to 4.8 I will list all three bug IDs when I push. Notes to reviewers: As with the fix of JDK-8199071 for FX 11, the bulk of the changes are in build.gradle to account for the change gradle made to generate classes in language-specific directories -- classes/java/main rather than just classes/main The newly added files are identical to those in jfx-dev, accounting for the different file name and preamble text for the third-party license file. Testing: - A full build and test on all three platforms - Compared artifacts from a full build before versus after the changes and ensured that the artifacts are the same
30-08-2018
We also need to bump the minimum version of gradle in 8u to 4.8 (see JDK-8209967), since the needed changes will not work with older versions of gradle.
25-08-2018
FX 8u fails to build with gradle 4.x. The backport to 8u will require changes similar to what was done in 11 for the following: JDK-8199071: Fix gradle deprecation warnings That isn't to say we will need to backport that fix (the changeset wouldn't be anything close to something we could backport), but rather that fix should inform this backport.
03-08-2018
Changeset: 6d614c816767 Author: kcr Date: 2018-06-07 10:50 -0700 URL: http://hg.openjdk.java.net/openjfx/jfx-dev/rt/rev/6d614c816767 8201553: Update FX build to use gradle 4.8 Reviewed-by: prr, jvos
07-06-2018
Merged into develop branch on GitHub: https://github.com/javafxports/openjdk-jfx/commit/04dc51b698347ce53420777abff4b2c472e45d32 Webrev for completeness: http://cr.openjdk.java.net/~kcr/8201553/webrev/
07-06-2018
+1 -phil.
06-06-2018
Proposed fix is here: https://github.com/javafxports/openjdk-jfx/pull/92
06-06-2018
Raising the priority to P2. This blocks both the swing interop work [1] and the building of maven bundles [2], in addition to bumping the minimum JDK to 10. Note that gradle 4.8 has now been released, so this can proceed. [1] JDK-8195811 [2] https://github.com/javafxports/openjdk-jfx/pull/83
05-06-2018
gradle 4.8 RC1 is now available. I was able to do a quick test build using jdk-11-ea+14 and gradle-4.8-rc-1. At this point I think it best to wait for gradle 4.8 to be released and then upgrade to it (it isn't worth the effort to transiently upgrade to gradle 4.6 or 4.7).
19-05-2018
Note that as an alternative, we could transiently update to gradle 4.6, and then update to gradle 4.8 later. The reason for doing this would be to get full JDK 10 support, which is blocking JDK-8200446. This might be a good option if the release of gradle 4.8 is delayed. Otherwise, it will be easier to wait.
13-04-2018