JDK-8200295 : Clean up jfrTypeIds.inline.hpp
  • Type: Enhancement
  • Component: hotspot
  • Sub-Component: jfr
  • Affected Version: 10,11
  • Priority: P4
  • Status: Open
  • Resolution: Unresolved
  • Submitted: 2018-03-27
  • Updated: 2021-01-07
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
Other
tbdUnresolved
Related Reports
Relates :  
JDK-8154079 - Catch incorrectly included .inline.hpp files
Relates :  
JDK-8204301 - Make OrderAccess functions available to hpp rather than inline.hpp files
Description
jfrTypeIds.inline.hpp is included from jfrEvent.hpp and jfrWriterLibrary.hpp. This needs to be cleaned up.
Comments
I did a partial cleanup of this but didn't know how to deal with jfrNativeEventWriter that is included in jfrEvent.hpp that causes some include files to be generated. I made a couple files into .inline.hpp and included them from the .cpp files that used them. Anyway, this is all but the last two in the list above. Hope this helps with this cleanup. open webrev at http://cr.openjdk.java.net/~coleenp/8200295.01/webrev
06-06-2018
share/jfr/recorder/service/jfrEvent.hpp:#include "jfr/recorder/jfrEventSetting.inline.hpp" share/jfr/recorder/checkpoint/jfrCheckpointWriter.hpp:#include "jfr/writers/jfrEventWriterHost.inline.hpp" share/jfr/recorder/checkpoint/jfrCheckpointWriter.hpp:#include "jfr/writers/jfrMemoryWriterHost.inline.hpp" share/jfr/recorder/checkpoint/types/traceid/jfrTraceIdMacros.hpp:#include "jfr/recorder/checkpoint/types/traceid/jfrTraceIdBits.inline.hpp" share/jfr/recorder/checkpoint/types/jfrTypeSetUtils.hpp:#include "jfr/recorder/checkpoint/types/traceid/jfrTraceId.inline.hpp" share/jfr/recorder/repository/jfrChunkWriter.hpp:#include "jfr/writers/jfrStreamWriterHost.inline.hpp" share/jfr/recorder/repository/jfrChunkWriter.hpp:#include "jfr/writers/jfrWriterHost.inline.hpp" share/jfr/leakprofiler/utilities/unifiedOop.hpp:#include "oops/oop.inline.hpp" share/jfr/leakprofiler/chains/bitset.hpp:#include "utilities/bitMap.inline.hpp" share/jfr/utilities/jfrHashtable.hpp:#include "memory/allocation.inline.hpp" share/jfr/utilities/jfrHashtable.hpp:#include "runtime/orderAccess.inline.hpp" share/jfr/writers/jfrStorageHost.hpp:#include "jfr/writers/jfrPosition.inline.hpp" share/jfr/writers/jfrEventWriterHost.hpp:#include "jfr/writers/jfrWriterHost.inline.hpp" share/jfr/writers/jfrStreamWriterHost.hpp:#include "jfr/writers/jfrMemoryWriterHost.inline.hpp" share/jfr/writers/jfrMemoryWriterHost.hpp:#include "jfr/writers/jfrStorageHost.inline.hpp" share/jfr/writers/jfrBigEndianWriter.hpp:#include "jfr/writers/jfrMemoryWriterHost.inline.hpp" share/jfr/writers/jfrBigEndianWriter.hpp:#include "jfr/writers/jfrWriterHost.inline.hpp" share/jfr/writers/jfrNativeEventWriter.hpp:#include "jfr/writers/jfrEventWriterHost.inline.hpp" share/jfr/writers/jfrNativeEventWriter.hpp:#include "jfr/writers/jfrMemoryWriterHost.inline.hpp"
31-05-2018