JDK-8199809 : Don't include frame.inline.hpp and other.inline.hpp from .hpp files
  • Type: Bug
  • Component: hotspot
  • Sub-Component: runtime
  • Affected Version: 11
  • Priority: P3
  • Status: Resolved
  • Resolution: Fixed
  • Submitted: 2018-03-19
  • Updated: 2024-10-28
  • Resolved: 2018-03-22
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 11
11 b07Fixed
Related Reports
Relates :  
JDK-8214787 - Zero builds fail with "undefined JavaThread::thread_state()"
Relates :  
JDK-8154079 - Catch incorrectly included .inline.hpp files
Relates :  
JDK-8200628 - aarch32 - Broken build after JDK-8199809
Relates :  
JDK-8200299 - Non-PCH build for aarch64 fails
Relates :  
JDK-8343167 - Unnecessary define checks in InterpreterRuntime after JDK-8199809
Description
... in accordance with the hotspot coding style guide.

Fixing these:

share/classfile/classFileParser.hpp:#include "runtime/handles.inline.hpp"
share/classfile/systemDictionary.hpp:#include "utilities/hashtable.inline.hpp"
share/runtime/javaFrameAnchor.hpp:#include "runtime/orderAccess.inline.hpp"
share/runtime/vframeArray.hpp:#include "runtime/frame.inline.hpp"
share/runtime/vframe.hpp:#include "runtime/frame.inline.hpp"
share/runtime/deoptimization.hpp:#include "runtime/frame.inline.hpp"
share/runtime/rframe.hpp:#include "runtime/frame.inline.hpp"
share/compiler/methodMatcher.hpp:#include "runtime/handles.inline.hpp"
share/interpreter/interpreterRuntime.hpp:#include "runtime/frame.inline.hpp"
share/interpreter/bytecodeStream.hpp:#include "runtime/handles.inline.hpp"
share/interpreter/rewriter.hpp:#include "runtime/handles.inline.hpp"
share/prims/methodHandles.hpp:#include "runtime/frame.inline.hpp"
share/prims/jvmtiEnvBase.hpp:#include "prims/jvmtiThreadState.inline.hpp"
share/prims/jvmtiEnvBase.hpp:#include "runtime/handles.inline.hpp"
share/services/threadService.hpp:#include "runtime/objectMonitor.inline.hpp"
share/memory/metaspaceShared.hpp:#include "oops/oop.inline.hpp"
share/oops/typeArrayOop.hpp:#include "runtime/orderAccess.inline.hpp"
Comments
URL: http://hg.openjdk.java.net/jdk/jdk/rev/d7df2dd501ce User: jwilhelm Date: 2018-03-29 19:35:31 +0000
29-03-2018
URL: http://hg.openjdk.java.net/jdk/hs/rev/d7df2dd501ce User: coleenp Date: 2018-03-21 23:45:59 +0000
22-03-2018
These are left and a lot more difficult because of platform included files: cpu/zero/interp_masm_zero.hpp:#include "assembler_zero.inline.hpp" share/c1/c1_MacroAssembler.hpp:#include "asm/macroAssembler.inline.hpp" cpu/x86/interp_masm_x86.hpp:#include "asm/macroAssembler.inline.hpp" cpu/aarch64/interp_masm_aarch64.hpp:#include "asm/macroAssembler.inline.hpp" cpu/arm/interp_masm_arm.hpp:#include "asm/macroAssembler.inline.hpp" cpu/sparc/interp_masm_sparc.hpp:#include "asm/macroAssembler.inline.hpp" And jvmci, which likely require splitting up the X macro to declare classes: share/jvmci/jvmciJavaClasses.hpp:#include "oops/access.inline.hpp" share/jvmci/jvmciJavaClasses.hpp:#include "oops/oop.inline.hpp" share/jvmci/jvmciJavaClasses.hpp:#include "runtime/jniHandles.inline.hpp" And ServiceUtil should be removed: share/services/serviceUtil.hpp:#include "oops/oop.inline.hpp"
19-03-2018