JDK-8197960 : [TESTBUG] remove/modify runtime tests which use java ee or corba modules
  • Type: Sub-task
  • Component: hotspot
  • Sub-Component: runtime
  • Affected Version: 11
  • Priority: P4
  • Status: Resolved
  • Resolution: Fixed
  • Submitted: 2018-02-14
  • Updated: 2019-06-20
  • Resolved: 2018-04-26
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 11
11 b12Fixed
Related Reports
Relates :  
JDK-8197959 - [TESTBUG] Some (App)CDS tests require modification due to the removal of the Java EE and CORBA modules
Description
the following tests are affected:

runtime/appcds/jigsaw/classpathtests/ClassPathTests.java 
runtime/appcds/jigsaw/overridetests/OverrideTests.java 
runtime/SharedArchiveFile/BootAppendTests.java 
runtime/modules/PatchModule/PatchModuleClassList.java 
runtime/AppCDS/HelloExtTest.java 
runtime/AppCDS/javaldr/CheckAnonymousClass.java
Comments
Only the module tests need to be fixed by this issue. Other tests are covered by the linked issue 8197959.
24-04-2018
The fix for JDK-8197959 is fixing these tests: runtime/appcds/jigsaw/classpathtests/ClassPathTests.java runtime/appcds/jigsaw/overridetests/OverrideTests.java runtime/SharedArchiveFile/BootAppendTests.java runtime/AppCDS/HelloExtTest.java runtime/AppCDS/javaldr/CheckAnonymousClass.java So, the fix for this task will only involve the remaining test: runtime/modules/PatchModule/PatchModuleClassList.java
24-04-2018
Here's a possible fix for test PatchModuleClassList.java: (Please don't remove that test.) @@ -1,5 +1,5 @@ /* - * Copyright (c) 2016, 2017, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2016, 2018, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -40,7 +40,7 @@ public class PatchModuleClassList { private static final String BOOT_CLASS = "javax/naming/spi/NamingManager"; - private static final String PLATFORM_CLASS = "javax/transaction/InvalidTransactionException"; + private static final String PLATFORM_CLASS = "java/sql/ResultSet"; public static void main(String args[]) throws Throwable { // Case 1. A class to be loaded by the boot class loader @@ -78,28 +78,28 @@ // Case 2. A class to be loaded by the platform class loader - // Create a class file in the module java.transaction. This class file - // will be put in the javatransaction.jar file. - source = "package javax.transaction; " + - "public class InvalidTransactionException { " + + // Create a class file in the module java.sql. This class file + // will be put in the javasql.jar file. + source = "package java.sql; " + + "public class ResultSet { " + " static { " + " System.out.println(\"I pass!\"); " + " } " + "}"; ClassFileInstaller.writeClassToDisk(PLATFORM_CLASS, - InMemoryJavaCompiler.compile(PLATFORM_CLASS.replace('/', '.'), source, "--patch-module=java.transaction"), + InMemoryJavaCompiler.compile(PLATFORM_CLASS.replace('/', '.'), source, "--patch-module=java.sql"), System.getProperty("test.classes")); - // Build the jar file that will be used for the module "java.transaction". - BasicJarBuilder.build("javatransaction", PLATFORM_CLASS); - moduleJar = BasicJarBuilder.getTestJar("javatransaction.jar"); + // Build the jar file that will be used for the module "java.sql". + BasicJarBuilder.build("javasql", PLATFORM_CLASS); + moduleJar = BasicJarBuilder.getTestJar("javasql.jar"); - classList = "javatransaction.list"; + classList = "javasql.list"; pb = ProcessTools.createJavaProcessBuilder( true, "-XX:DumpLoadedClassList=" + classList, - "--patch-module=java.naming=" + moduleJar, + "--patch-module=java.sql=" + moduleJar, "PatchModuleMain", PLATFORM_CLASS.replace('/', '.')); new OutputAnalyzer(pb.start()).shouldHaveExitValue(0);
23-04-2018