Bug ID: JDK-8194859 Bad backport of 8024468 breaks Zero build due to lack of 8010862 in OpenJDK 7

Versions (Unresolved/Resolved/Fixed)

The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.

Other
openjdk7uFixed

/home/andrew/projects/openjdk/upstream/jdk7/hotspot/src/cpu/zero/vm/cppInterpreter_zero.cpp: In static member function 'static int CppInterpreter::native_entry(methodOop, intptr_t, Thread*)':
/home/andrew/projects/openjdk/upstream/jdk7/hotspot/src/cpu/zero/vm/cppInterpreter_zero.cpp:253:42: error: 'mcs' was not declared in this scope
     if (counter->reached_InvocationLimit(mcs->backedge_counter())) {
                                          ^~~
make[6]: *** [/home/andrew/projects/openjdk/upstream/jdk7/hotspot/make/linux/makefiles/rules.make:151: cppInterpreter_zero.o] Error 1

mcs is only added by 8013607 (not in OpenJDK 7):

diff --git a/src/cpu/zero/vm/cppInterpreter_zero.cpp b/src/cpu/zero/vm/cppInterpreter_zero.cpp
--- a/src/cpu/zero/vm/cppInterpreter_zero.cpp
+++ b/src/cpu/zero/vm/cppInterpreter_zero.cpp
@@ -212,7 +212,13 @@
 
   // Update the invocation counter
   if ((UseCompiler || CountCompiledCalls) && !method->is_synchronized()) {
-    InvocationCounter *counter = method->invocation_counter();
+    MethodCounters* mcs = method->method_counters();
+    if (mcs == NULL) {
+      CALL_VM_NOCHECK(mcs = InterpreterRuntime::build_method_counters(thread, method));
+      if (HAS_PENDING_EXCEPTION)
+        goto unwind_and_return;
+    }
+    InvocationCounter *counter = mcs->invocation_counter();
     counter->increment();
     if (counter->reached_InvocationLimit()) {
       CALL_VM_NOCHECK(

This issue had fix version 7 when the fix was pushed to 7u so a backport was created automatically. Copy of HG Updates comment: HG Updates added a comment - 2018-03-21 17:25 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/hotspot/rev/d8a079873393 User: andrew Date: 2018-03-21 16:23:50 +0000

19-09-2018

Relates :	JDK-8024468 - PPC64 (part 201): cppInterpreter: implement bytecode profiling
Relates :	JDK-8010862 - The Method counter fields used for profiling can be allocated lazily