JDK-8194294 : [TEST BUG] Manual Test for WebView FileReader API
  • Type: Bug
  • Component: javafx
  • Sub-Component: web
  • Affected Version: 8,9,openjfx11
  • Priority: P4
  • Status: Resolved
  • Resolution: Fixed
  • OS: generic
  • CPU: generic
  • Submitted: 2018-01-02
  • Updated: 2018-06-13
  • Resolved: 2018-01-17
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 10 JDK 8 Other
10Fixed 8u172Fixed openjfx11Fixed
Related Reports
Relates :  
Description
Add Manual test for FileReader API 
 - Should read the file content of input file,
Comments
Changeset: 7d171e79236c Author: ghb Date: 2018-01-17 09:13 +0530 URL: http://hg.openjdk.java.net/openjfx/jfx-dev/tests/rev/7d171e79236c
17-01-2018

+1
15-01-2018

Thanks [~ghb] lgtm, +1
03-01-2018

Updated webrev : http://cr.openjdk.java.net/~ghb/8194294/webrev.02/
03-01-2018

[~ghb] These two comments have not been addressed -For readibility, better to use quotes for attribute values -- input and p tag attributes are missing quotes -- single and double quotes used in getElementById. I feel its better we stick to one convention -loadend event handler should ideally be registered prior to readAsText call Apart from these, changes look fine to me.
03-01-2018

Thanks [~rkamath], Updated webrev : http://cr.openjdk.java.net/~ghb/8194294/webrev.01/
03-01-2018

Few comments: FileReader.java -Mixed case for test case name filereader.html -Script block not used. Can remove resources/filereader.html -For readibility, better to use quotes for attribute values -statusElement can be moved inside function onInputFileChange -loadend event handler should be registered prior to readAsText call -Guess the eventsender functionality is not required?
02-01-2018

Solution : http://cr.openjdk.java.net/~ghb/8194294/webrev.00/ Run "FileReader test" (webnode -- tests-- html5 -- input -- file -- FileReader).
02-01-2018