JDK-8193494 : Add a regression test case for JDK-8183100
  • Type: Bug
  • Component: javafx
  • Sub-Component: controls
  • Affected Version: 8u102,10
  • Priority: P4
  • Status: Resolved
  • Resolution: Fixed
  • OS: generic
  • CPU: generic
  • Submitted: 2017-12-14
  • Updated: 2020-01-31
  • Resolved: 2017-12-22
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 10 JDK 8
10Fixed 8u192Fixed
Related Reports
Relates :  
JDK-8183100 - Styles not applied reliably after Java 8u92
Description
JDK-8151756 was fixed in JDK 9 and JDK 8u.
The fix had caused regressions (JDK-8185709, JDK-8183100, JDK-8168951).
Hence, the original fix was reverted using ID JDK-8183100.

This bug is to add a regression test case that broke visual styling with JDK-8151756 & reverted with JDK-8183100.
Refer to manual test cases attached JDK-8185709, JDK-8183100, JDK-8168951.
Comments
Looks good. There is an extra blank line added at the end of the file that you might want to remove (no need for a new webrev if you do). +1 Approved to push to 8u-dev for 8u182.
30-01-2018
Thanks for the review. Here is the updated patch with corrected package name- http://cr.openjdk.java.net/~aghaisas/fx/8193494/8u/webrev.1/
30-01-2018
The directory in which the test lives does not match the package name. Note that "src/test/java" is the root directory of the test sources, and not part of the package name, so the fact that it works at all is somewhat accidental. Based on where the test lives, you need to change the package name to "javafx.scene" so that it matches. As it stands, running this as a single test using the standard syntax for such will fail to find the class file: gradle -PFULL_TEST=true :systemTests:cleanTest :systemTests:test --tests javafx.scene.JDK8183100Test
29-01-2018
This is 8u backport of above fix : Request you to review : http://cr.openjdk.java.net/~aghaisas/fx/8193494/8u/webrev.0/
29-01-2018
This test should be backported to JDK 8u-dev at some point.
11-01-2018
Hi Ajit, The change looks good, A small comment on the imports, these three imports can be removed, import javafx.scene.Group; import javafx.scene.layout.GridPane; import javafx.scene.shape.Rectangle; +1 with small change.
22-12-2017
The .1 webrev looks good. +1
21-12-2017
I had tested it on Windows and Linux. This test fails on Mac - Button mnemonics are not working on Mac. I have an alternate solution. I will put an updated webrev for review.
21-12-2017
Thanks Kevin for the review. 1) I have modified the test NOT to use mnemonics, but key accelerators. It passes on Windows, Linux and Mac. 2) I have increased timeout to 15 sec. Here is the updated webrev for review. http://cr.openjdk.java.net/~aghaisas/fx/8193494/webrev.1/
21-12-2017
The test looks good. My only comment is that I recommend to increase the time to 10 or 15 seconds (it takes 3 seconds to run on Linux and the very first time I ran it it timed out). Have you tested on all three platforms? +1 pending the change to the test timeout value.
20-12-2017
I have added a systemTest. Request you to review. http://cr.openjdk.java.net/~aghaisas/fx/8193494/webrev.0/
20-12-2017