JDK-8193492 : tools/launcher/VersionCheck.java need to be updated after JDK-8191054
  • Type: Bug
  • Component: tools
  • Sub-Component: javah
  • Affected Version: 10
  • Priority: P2
  • Status: Closed
  • Resolution: Duplicate
  • Submitted: 2017-12-14
  • Updated: 2017-12-14
  • Resolved: 2017-12-14
Related Reports
Relates :  
Description
It failed with:
java.lang.AssertionError: VersionCheck failed: testToolVersion: [javah]; 
	at VersionCheck.main(VersionCheck.java:287)
Comments
When I do a build of the JDK with JDK-8191054, a javah binary still appears in the bin directory. The javah implementation is not present however, which causes the test to fail. I haven't done a build with the change yet, but something like diff -r 984c4b99afc9 make/common/JavaCompilation.gmk --- a/make/common/JavaCompilation.gmk Wed Dec 13 19:48:03 2017 -0800 +++ b/make/common/JavaCompilation.gmk Thu Dec 14 00:37:01 2017 -0800 @@ -46,7 +46,7 @@ # passed to SetupJavaCompilation. This name is used as variable prefix. # # Remaining parameters are named arguments. These include: -# JVM:=The jvm used to run the javac/javah command +# JVM:=The jvm used to run the javac command # JAVAC:=The javac jar and bootstrap classpath changes, or just bin/javac if JVM is left out # FLAGS:=Flags to be supplied to javac # SERVER_DIR:=Use a javac server (-XDserver) and store the server related files here diff -r 984c4b99afc9 make/launcher/Launcher-jdk.compiler.gmk --- a/make/launcher/Launcher-jdk.compiler.gmk Wed Dec 13 19:48:03 2017 -0800 +++ b/make/launcher/Launcher-jdk.compiler.gmk Thu Dec 14 00:37:01 2017 -0800 @@ -31,11 +31,6 @@ CFLAGS := -DEXPAND_CLASSPATH_WILDCARDS, \ )) -$(eval $(call SetupBuildLauncher, javah, \ - MAIN_CLASS := com.sun.tools.javah.Main, \ - CFLAGS := -DEXPAND_CLASSPATH_WILDCARDS, \ -)) - $(eval $(call SetupBuildLauncher, serialver, \ MAIN_CLASS := sun.tools.serialver.SerialVer, \ CFLAGS := -DEXPAND_CLASSPATH_WILDCARDS, \ might do the trick. HTH
14-12-2017

This has been fixed as JDK-8193503.
14-12-2017