JDK-8193135 : get rid of redundant _smr_ prefix/infix in ThreadSMRSupport stuff
- Type: Bug
- Component: hotspot
- Sub-Component: runtime
- Affected Version: 10
- Priority: P4
- Status: Resolved
- Resolution: Fixed
- OS: generic
- CPU: generic
- Submitted: 2017-12-06
- Updated: 2018-01-04
- Resolved: 2017-12-08
The Version table provides details related to the release that this issue/RFE will be addressed.
Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.
To download the current JDK release, click here.
Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.
To download the current JDK release, click here.
| JDK 10 | JDK 11 |
|---|---|
10 b37Fixed  |
11Fixed |
Related Reports
|
Relates :
|
|
|
Relates :
|
Description
Stefan K code review comment on the fix for: JDK-8191789 migrate more Thread-SMR stuff from thread.[ch]pp -> threadSMR.[ch]pp >>> ======================================================================== >>> http://cr.openjdk.java.net/~dcubed/8191789-webrev/jdk10-0/src/hotspot/share/runtime/threadSMR.hpp.udiff.html >>> >>> Now that you have moved all these functions and variables to a class named ThreadsSMRSupport maybe you want to consider getting rid of the redundant _smr_ prefix/infix? >> >> I thought about that, but it made the sanity checking phase much more >> difficult because of the noise level in the diffs. What I could do is >> make that change as the last patch before qfold and qfinish... >> > > It makes sense to me to not change it while moving the files. I think > its better to push that change as a separate RFE. Okay. I'll take it on as a separate changeset.
Comments
|